Allow constructor and method signatures in classes

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 7864 matching lines @@
   const char* correct_data[] = {
     "class C { f(x: number) : boolean { return x == 42; } }",
     "class D extends C { g<A>(x: A[]) : A { return x[0]; } }",
     "class E extends D implements I, J {}",
     "class F<A> extends D implements I<A>, J<number, A> {}",
     "class C { x; y=42; z: number; w: number = 17; }",
     "class C { [x: string]; }",
     "class C { [x: number]; }",
     "class C { [x: string] : boolean; }",
     "class C { [x: number] : boolean; }",
+    "class C { constructor (x: number); constructor (x) {} }",

[rossberg, 2016/04/18 11:13:10]

Also try in the opposite order.

[nickie, 2016/04/18 12:35:09]

It is not 100% clear if that should be valid or not.  As I understand it, the
idea in TS is that you can have zero or more function/method/constructor
signatures before the (single) implementation of the
function/method/constructor.

A test with those reversed would pass here because, after parsing, these
signatures are equivalent to empty statements.  But I think it would be
misleading to include such tests, which fail in TS (with a semantic error).

+    "class C { f (x: number) : number; f (x) { return x; } }",

[rossberg, 2016/04/18 11:13:10]

Same here.

     NULL
   };
 
   const char* error_data[] = {
     "class C { f(x: number) : () {} }",
     "class D implements () {}",
     "class E implements number[] {}",
     "class F implements I<> {}",
     "class E<> {}",
     "class C { x: (); }",
     "class C { [42]; }",
     "class C { [42] : number; }",
     "class C { [x: any]; }",
     "class C { [x: any] : any; }",
     "class C { static [x: number]; }",
+    "class C { constructor (x: number) : number; constructor (x) {} }",
     NULL
   };
 
   static const ParserFlag always_flags[] = {kAllowTypes};
   RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
   RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0,
                     always_flags, arraysize(always_flags));
   RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
@@ skipping 24 matching lines @@
   static const ParserFlag always_flags[] = {kAllowTypes};
   RunParserSyncTest(untyped_context_data, correct_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
   RunParserSyncTest(typed_context_data, correct_data, kSuccess, NULL, 0,
                     always_flags, arraysize(always_flags));
   RunParserSyncTest(untyped_context_data, error_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
   RunParserSyncTest(typed_context_data, error_data, kError, NULL, 0,
                     always_flags, arraysize(always_flags));
 }