Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849803002: Add parsing for interface declarations (Closed)

Created:
4 years, 8 months ago by nickie
Modified:
4 years, 8 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@types-1850663002-class-decl
Target Ref:
refs/pending/heads/experimental/nikolaos/types
Project:
v8
Visibility:
Public.

Description

Add parsing for interface declarations This is based on https://codereview.chromium.org/1850663002 R=rossberg@chromium.org BUG= NOTRY=true NOPRESUBMIT=true

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add more tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -21 lines) Patch
M src/parsing/parser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M src/parsing/parser-base.h View 4 chunks +69 lines, -17 lines 0 comments Download
M src/parsing/preparser.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 1 1 chunk +33 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/typesystem/interface-declarations.js View 1 chunk +51 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1850663002 Patch 20001

Messages

Total messages: 5 (1 generated)
nickie
4 years, 8 months ago (2016-03-31 15:57:49 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1849803002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1849803002/diff/1/test/cctest/test-parsing.cc#newcode7928 test/cctest/test-parsing.cc:7928: "interface I { x: () }", interface {} ...
4 years, 8 months ago (2016-04-18 11:06:23 UTC) #2
nickie
https://codereview.chromium.org/1849803002/diff/1/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1849803002/diff/1/test/cctest/test-parsing.cc#newcode7928 test/cctest/test-parsing.cc:7928: "interface I { x: () }", On 2016/04/18 11:06:23, ...
4 years, 8 months ago (2016-04-19 17:19:02 UTC) #3
nickie
4 years, 8 months ago (2016-04-20 14:12:29 UTC) #4 
Patchset 2 landed MANUALLY in experimental/nikolaos/types as:
31a970faaaa2a2bbc920fafb997e3a9a53bb77b8
https://chromium.googlesource.com/v8/v8/+/31a970faaaa2a2bbc920fafb997e3a9a53b...

Powered by Google App Engine
This is Rietveld 408576698