Merge/rename two MediaControlElements into their parent classes

Merge/rename two MediaControlElements into their parent classes

MediaControlPanelMuteButtonElement/MediaControlPanelVolumeSliderElement
were the only classes that inherited
MediaControlMuteButtonElement/MediaControlVolumeSliderElement.

Remove the m_panelMuteButton->show() in MediaControls::reset(), because
there is nothing that ever hides the button in the first place.

BUG=341813
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168572

[philipj_slow, 2014-03-04 08:15:30]

Depends on:
https://codereview.chromium.org/182383006/
https://codereview.chromium.org/177423011/
https://codereview.chromium.org/176883020/

[nessy, 2014-03-04 22:43:56]

Sigh, all this work that needs to be done to undo the controls unification that
I did between Safari and Chrome.

Glad somebody is cleaning this up!

[acolwell GONE FROM CHROMIUM, 2014-03-04 23:49:27]

lgtm

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControlElements.cpp (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControlElements.cpp:533: if (event->isMouseEvent()
&& toMouseEvent(event)->button())
nit: Can we add == LeftButton so the comment isn't necessary?

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControlElements.h (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControlElements.h:107: virtual bool
willRespondToMouseMoveEvents() OVERRIDE { return true; }
Do we still need this? It doesn't look like we actually do anything with mouse
move events anymore.

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControls.cpp:185: m_panelMuteButton->show();
No longer needed because it is never hidden?

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControls.cpp:186: m_volumeSlider->hide();
We hide the volume slider, but not the mute button?

[philipj_slow, 2014-03-05 13:12:07]

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControlElements.cpp (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControlElements.cpp:533: if (event->isMouseEvent()
&& toMouseEvent(event)->button())
On 2014/03/04 23:49:28, acolwell wrote:
> nit: Can we add == LeftButton so the comment isn't necessary?

Done.

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControlElements.h (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControlElements.h:107: virtual bool
willRespondToMouseMoveEvents() OVERRIDE { return true; }
On 2014/03/04 23:49:28, acolwell wrote:
> Do we still need this? It doesn't look like we actually do anything with mouse
> move events anymore.

Good catch. We should have willRespondToMouseClickEvents() though, which I
accidentally removed.

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControls.cpp (left):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControls.cpp:185: m_panelMuteButton->show();
On 2014/03/04 23:49:28, acolwell wrote:
> No longer needed because it is never hidden?

Indeed, "there is nothing that ever hides the button in the first place".

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
File Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/185363011/diff/20001/Source/core/html/shadow/...
Source/core/html/shadow/MediaControls.cpp:186: m_volumeSlider->hide();
On 2014/03/04 23:49:28, acolwell wrote:
> We hide the volume slider, but not the mute button?

Yeah, my guess is that once upon a time the mute button had a "no audio
available" state (Presto had this) or someone planned for it. Or nobody ever
tested with a resource without an audio track...

[philipj_slow, 2014-03-05 13:12:15]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-03-05 13:12:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/185363011/40001

[commit-bot: I haz the power, 2014-03-05 20:58:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/185363011/40001

[commit-bot: I haz the power, 2014-03-06 04:22:09]

Change committed as 168572