Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/html/shadow/MediaControlElements.h

Issue 185363011: Merge/rename two MediaControlElements into their parent classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rm m_muteButton->show() Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 82 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 public: 93 public:
94 static PassRefPtr<MediaControlOverlayEnclosureElement> create(Document&); 94 static PassRefPtr<MediaControlOverlayEnclosureElement> create(Document&);
95 95
96 private: 96 private:
97 explicit MediaControlOverlayEnclosureElement(Document&); 97 explicit MediaControlOverlayEnclosureElement(Document&);
98 virtual const AtomicString& shadowPseudoId() const OVERRIDE; 98 virtual const AtomicString& shadowPseudoId() const OVERRIDE;
99 }; 99 };
100 100
101 // ---------------------------- 101 // ----------------------------
102 102
103 class MediaControlPanelMuteButtonElement FINAL : public MediaControlMuteButtonEl ement { 103 class MediaControlMuteButtonElement FINAL : public MediaControlInputElement {
104 public: 104 public:
105 static PassRefPtr<MediaControlPanelMuteButtonElement> create(Document&, Medi aControls*); 105 static PassRefPtr<MediaControlMuteButtonElement> create(Document&);
106 106
107 virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; } 107 virtual bool willRespondToMouseMoveEvents() OVERRIDE { return true; }
acolwell GONE FROM CHROMIUM 2014/03/04 23:49:28 Do we still need this? It doesn't look like we act
philipj_slow 2014/03/05 13:12:08 Good catch. We should have willRespondToMouseClick
108 virtual void updateDisplayType() OVERRIDE;
108 109
109 private: 110 private:
110 explicit MediaControlPanelMuteButtonElement(Document&, MediaControls*); 111 explicit MediaControlMuteButtonElement(Document&);
111 112
112 virtual const AtomicString& shadowPseudoId() const OVERRIDE; 113 virtual const AtomicString& shadowPseudoId() const OVERRIDE;
114 virtual void defaultEventHandler(Event*) OVERRIDE;
113 }; 115 };
114 116
115 // ---------------------------- 117 // ----------------------------
116 118
117 class MediaControlPlayButtonElement FINAL : public MediaControlInputElement { 119 class MediaControlPlayButtonElement FINAL : public MediaControlInputElement {
118 public: 120 public:
119 static PassRefPtr<MediaControlPlayButtonElement> create(Document&); 121 static PassRefPtr<MediaControlPlayButtonElement> create(Document&);
120 122
121 virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; } 123 virtual bool willRespondToMouseClickEvents() OVERRIDE { return true; }
122 virtual void updateDisplayType() OVERRIDE; 124 virtual void updateDisplayType() OVERRIDE;
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 194
193 private: 195 private:
194 explicit MediaControlFullscreenButtonElement(Document&); 196 explicit MediaControlFullscreenButtonElement(Document&);
195 197
196 virtual const AtomicString& shadowPseudoId() const OVERRIDE; 198 virtual const AtomicString& shadowPseudoId() const OVERRIDE;
197 virtual void defaultEventHandler(Event*) OVERRIDE; 199 virtual void defaultEventHandler(Event*) OVERRIDE;
198 }; 200 };
199 201
200 // ---------------------------- 202 // ----------------------------
201 203
202 class MediaControlPanelVolumeSliderElement FINAL : public MediaControlVolumeSlid erElement { 204 class MediaControlVolumeSliderElement FINAL : public MediaControlInputElement {
203 public: 205 public:
204 static PassRefPtr<MediaControlPanelVolumeSliderElement> create(Document&); 206 static PassRefPtr<MediaControlVolumeSliderElement> create(Document&);
207
208 virtual bool willRespondToMouseMoveEvents() OVERRIDE;
209 virtual bool willRespondToMouseClickEvents() OVERRIDE;
210 void setVolume(double);
205 211
206 private: 212 private:
207 explicit MediaControlPanelVolumeSliderElement(Document&); 213 explicit MediaControlVolumeSliderElement(Document&);
214
208 virtual const AtomicString& shadowPseudoId() const OVERRIDE; 215 virtual const AtomicString& shadowPseudoId() const OVERRIDE;
216 virtual void defaultEventHandler(Event*) OVERRIDE;
209 }; 217 };
210 218
211 // ---------------------------- 219 // ----------------------------
212 220
213 class MediaControlTimeRemainingDisplayElement FINAL : public MediaControlTimeDis playElement { 221 class MediaControlTimeRemainingDisplayElement FINAL : public MediaControlTimeDis playElement {
214 public: 222 public:
215 static PassRefPtr<MediaControlTimeRemainingDisplayElement> create(Document&) ; 223 static PassRefPtr<MediaControlTimeRemainingDisplayElement> create(Document&) ;
216 224
217 private: 225 private:
218 explicit MediaControlTimeRemainingDisplayElement(Document&); 226 explicit MediaControlTimeRemainingDisplayElement(Document&);
(...skipping 28 matching lines...) Expand all
247 virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE; 255 virtual RenderObject* createRenderer(RenderStyle*) OVERRIDE;
248 256
249 IntRect m_videoDisplaySize; 257 IntRect m_videoDisplaySize;
250 float m_fontSize; 258 float m_fontSize;
251 }; 259 };
252 260
253 261
254 } // namespace WebCore 262 } // namespace WebCore
255 263
256 #endif // MediaControlElements_h 264 #endif // MediaControlElements_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698