Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 185363011: Merge/rename two MediaControlElements into their parent classes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: nit/oops Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControls.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControls.cpp
diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp
index 481618911dd4e848dc775768657b03cc5d3b471a..dcac50573138b68da29e4ff68da25d4eee997cb2 100644
--- a/Source/core/html/shadow/MediaControls.cpp
+++ b/Source/core/html/shadow/MediaControls.cpp
@@ -44,7 +44,7 @@ MediaControls::MediaControls(Document& document)
, m_playButton(0)
, m_currentTimeDisplay(0)
, m_timeline(0)
- , m_panelMuteButton(0)
+ , m_muteButton(0)
, m_volumeSlider(0)
, m_toggleClosedCaptionsButton(0)
, m_fullScreenButton(0)
@@ -108,13 +108,13 @@ bool MediaControls::initializeControls(Document& document)
if (exceptionState.hadException())
return false;
- RefPtr<MediaControlPanelMuteButtonElement> panelMuteButton = MediaControlPanelMuteButtonElement::create(document, this);
- m_panelMuteButton = panelMuteButton.get();
- panel->appendChild(panelMuteButton.release(), exceptionState);
+ RefPtr<MediaControlMuteButtonElement> muteButton = MediaControlMuteButtonElement::create(document);
+ m_muteButton = muteButton.get();
+ panel->appendChild(muteButton.release(), exceptionState);
if (exceptionState.hadException())
return false;
- RefPtr<MediaControlPanelVolumeSliderElement> slider = MediaControlPanelVolumeSliderElement::create(document);
+ RefPtr<MediaControlVolumeSliderElement> slider = MediaControlVolumeSliderElement::create(document);
m_volumeSlider = slider.get();
panel->appendChild(slider.release(), exceptionState);
if (exceptionState.hadException())
@@ -157,7 +157,7 @@ void MediaControls::setMediaController(MediaControllerInterface* controller)
m_playButton->setMediaController(controller);
m_currentTimeDisplay->setMediaController(controller);
m_timeline->setMediaController(controller);
- m_panelMuteButton->setMediaController(controller);
+ m_muteButton->setMediaController(controller);
m_volumeSlider->setMediaController(controller);
m_toggleClosedCaptionsButton->setMediaController(controller);
m_fullScreenButton->setMediaController(controller);
@@ -182,8 +182,6 @@ void MediaControls::reset()
m_timeline->setDuration(m_mediaController->duration());
m_timeline->setPosition(m_mediaController->currentTime());
- m_panelMuteButton->show();
-
if (!m_mediaController->hasAudio()) {
m_volumeSlider->hide();
} else {
@@ -291,7 +289,7 @@ void MediaControls::updateCurrentTimeDisplay()
void MediaControls::changedMute()
{
- m_panelMuteButton->changedMute();
+ m_muteButton->updateDisplayType();
if (m_mediaController->muted())
m_volumeSlider->setVolume(0);
@@ -302,8 +300,8 @@ void MediaControls::changedMute()
void MediaControls::changedVolume()
{
m_volumeSlider->setVolume(m_mediaController->volume());
- if (m_panelMuteButton->renderer())
- m_panelMuteButton->renderer()->repaint();
+ if (m_muteButton->renderer())
+ m_muteButton->renderer()->repaint();
}
void MediaControls::changedClosedCaptionsVisibility()
« no previous file with comments | « Source/core/html/shadow/MediaControls.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698