[wasm] Refactoring of wasm-external-refs.

[wasm] Refactoring of wasm-external-refs.

1) I moved the implementations of the wrapper functions into a new cc
file so that I can use these wrapper functions in tests.

2) I made a generic test for all tests in
test-run-calls-to-external-references.cc. In the new test we only
compare the result of a function call through an external reference with
the result of a direct function call. This is sufficient because we only
want to test function calls through external references work here.
The implementation of these functions are tested somewhere else.

R=titzer@chromium.org

Committed: https://crrev.com/a7d3e24fd67a36d37efba9ca5b400642cb808169
Cr-Commit-Position: refs/heads/master@{#35289}

[titzer, 2016-04-04 12:45:30]

lgtm modulo possible loss of test coverage.

https://codereview.chromium.org/1853123002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-calls-to-external-references.cc (left):

https://codereview.chromium.org/1853123002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-calls-to-external-references.cc:101: } values[] =
{{0x0, 0x0},
Can we make sure these input tests get moved somewhere as well, e.g. to the WASM
tests?

[ahaas, 2016-04-04 12:50:40]

https://codereview.chromium.org/1853123002/diff/1/test/cctest/compiler/test-r...
File test/cctest/compiler/test-run-calls-to-external-references.cc (left):

https://codereview.chromium.org/1853123002/diff/1/test/cctest/compiler/test-r...
test/cctest/compiler/test-run-calls-to-external-references.cc:101: } values[] =
{{0x0, 0x0},
On 2016/04/04 at 12:45:30, titzer wrote:
> Can we make sure these input tests get moved somewhere as well, e.g. to the
WASM tests?

These input tests already exist in test-run-wasm-64.cc.

[ahaas, 2016-04-04 12:50:43]

The CQ bit was checked by ahaas@chromium.org

[commit-bot: I haz the power, 2016-04-04 12:50:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853123002/1

[commit-bot: I haz the power, 2016-04-04 13:29:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 13:29:38]

Try jobs failed on following builders:
  v8_win_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/5205)
  v8_win_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng_triggered/bui...)

[ahaas, 2016-04-06 09:08:34]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-04-06 09:08:34]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/1853123002/#ps20001
(title: "Additional include for windows.")

[commit-bot: I haz the power, 2016-04-06 09:08:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1853123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1853123002/20001

[commit-bot: I haz the power, 2016-04-06 09:24:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-06 09:26:12]

Description was changed from

==========
[wasm] Refactoring of wasm-external-refs.

1) I moved the implementations of the wrapper functions into a new cc
file so that I can use these wrapper functions in tests.

2) I made a generic test for all tests in
test-run-calls-to-external-references.cc. In the new test we only
compare the result of a function call through an external reference with
the result of a direct function call. This is sufficient because we only
want to test function calls through external references work here.
The implementation of these functions are tested somewhere else.

R=titzer@chromium.org
==========

to

==========
[wasm] Refactoring of wasm-external-refs.

1) I moved the implementations of the wrapper functions into a new cc
file so that I can use these wrapper functions in tests.

2) I made a generic test for all tests in
test-run-calls-to-external-references.cc. In the new test we only
compare the result of a function call through an external reference with
the result of a direct function call. This is sufficient because we only
want to test function calls through external references work here.
The implementation of these functions are tested somewhere else.

R=titzer@chromium.org

Committed: https://crrev.com/a7d3e24fd67a36d37efba9ca5b400642cb808169
Cr-Commit-Position: refs/heads/master@{#35289}
==========

[commit-bot: I haz the power, 2016-04-06 09:26:13]

Patchset 2 (id:??) landed as
https://crrev.com/a7d3e24fd67a36d37efba9ca5b400642cb808169
Cr-Commit-Position: refs/heads/master@{#35289}