Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1852273002: Revert of Update SkXfermodeImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update SkXfermodeImageFilter to sk_sp (patchset #4 id:60001 of https://codereview.chromium.org/1852123002/ ) Reason for revert: Chrome-land compilation failure. Original issue's description: > Update SkXfermodeImageFilter to sk_sp > > TBR=reed@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1852123002 > > Committed: https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8 TBR=fmalita@chromium.org,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b591c77c3770a3216ce75c8b77f1017c917db1f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -63 lines) Patch
M gm/imagefiltersgraph.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 9 chunks +15 lines, -14 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 2 chunks +7 lines, -11 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 chunk +6 lines, -3 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +6 lines, -7 lines 0 comments Download
M tests/ImageFilterTest.cpp View 5 chunks +13 lines, -20 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Update SkXfermodeImageFilter to sk_sp
4 years, 8 months ago (2016-04-04 15:06:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852273002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852273002/1
4 years, 8 months ago (2016-04-04 15:06:10 UTC) #2
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 15:06:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b591c77c3770a3216ce75c8b77f1017c917db1f9

Powered by Google App Engine
This is Rietveld 408576698