Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 1852123002: Update SkXfermodeImageFilter to sk_sp (Closed)

Created:
4 years, 8 months ago by robertphillips
Modified:
4 years, 8 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : clean up #

Patch Set 3 : update to ToT #

Patch Set 4 : update to ToT #

Patch Set 5 : update to ToT #

Patch Set 6 : Overload Make methods #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -115 lines) Patch
M bench/ColorFilterBench.cpp View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M gm/imagefiltersgraph.cpp View 1 2 3 4 5 3 chunks +6 lines, -3 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 9 chunks +14 lines, -15 lines 0 comments Download
M include/effects/SkXfermodeImageFilter.h View 1 2 3 4 2 chunks +23 lines, -7 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 1 2 3 4 5 1 chunk +3 lines, -6 lines 0 comments Download
M src/effects/SkXfermodeImageFilter.cpp View 1 chunk +7 lines, -6 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 2 3 4 5 5 chunks +13 lines, -15 lines 0 comments Download
A + tests/ImageFilterTest.cpp.orig View 1 2 3 4 5 14 chunks +48 lines, -61 lines 0 comments Download
A tests/ImageFilterTest.cpp.rej View 1 2 3 4 5 1 chunk +20 lines, -0 lines 0 comments Download
M tests/SerializationTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 34 (17 generated)
robertphillips
4 years, 8 months ago (2016-04-03 20:56:20 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852123002/20001
4 years, 8 months ago (2016-04-03 20:58:09 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 21:08:22 UTC) #8
reed1
lgtm
4 years, 8 months ago (2016-04-03 21:31:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852123002/60001
4 years, 8 months ago (2016-04-04 12:10:58 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-04 12:22:29 UTC) #13
f(malita)
lgtm
4 years, 8 months ago (2016-04-04 14:04:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852123002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852123002/60001
4 years, 8 months ago (2016-04-04 14:12:56 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/3bc969264d4720d67f0b137552b3777a03b431a8
4 years, 8 months ago (2016-04-04 14:13:54 UTC) #19
robertphillips
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1852273002/ by robertphillips@google.com. ...
4 years, 8 months ago (2016-04-04 15:06:05 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852123002/120001
4 years, 8 months ago (2016-04-05 19:33:16 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 19:46:07 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1852123002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1852123002/120001
4 years, 8 months ago (2016-04-05 19:47:37 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:120001) as https://skia.googlesource.com/skia/+/8c0326df5f600da43a054dad3b354221dd6b790f
4 years, 8 months ago (2016-04-05 19:48:40 UTC) #31
Takashi Toyoshima
Probably adding .orig and .rej in the patch set 6 was a mistake? I just ...
4 years, 8 months ago (2016-04-21 03:55:57 UTC) #32
robertphillips
On 2016/04/21 03:55:57, toyoshim wrote: > Probably adding .orig and .rej in the patch set ...
4 years, 8 months ago (2016-04-21 11:37:58 UTC) #33
robertphillips
4 years, 8 months ago (2016-04-21 15:20:02 UTC) #34
Message was sent while issue was closed.
On 2016/04/21 11:37:58, robertphillips wrote:
> On 2016/04/21 03:55:57, toyoshim wrote:
> > Probably adding .orig and .rej in the patch set 6 was a mistake?
> > I just notice this b y running rm `find . -name \*.rej` to remove locally
> > rejected patches.
> 
> Hmmm .. odd. How did those creep in. Thanks for letting me know.

They should be removed in https://codereview.chromium.org/1912583002 (Remove
stray files)

Powered by Google App Engine
This is Rietveld 408576698