tests/SerializationTest.cpp - Issue 1852273002: Revert of Update SkXfermodeImageFilter to sk_sp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SerializationTest.cpp

Issue 1852273002: Revert of Update SkXfermodeImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SerializationTest.cpp

diff --git a/tests/SerializationTest.cpp b/tests/SerializationTest.cpp

index 9bdfe1e0e622e9af6b20f026481af48b3ff8f321..15b73827ae2780470940a565100f8fe6ecab9380 100644

--- a/tests/SerializationTest.cpp

+++ b/tests/SerializationTest.cpp

@@ -248,8 +248,7 @@

sk_sp<SkImageFilter> invalidBitmapSource(SkImageSource::Make(std::move(invalidImage)));

sk_sp<SkImageFilter> xfermodeImageFilter(

SkXfermodeImageFilter::Make(SkXfermode::Make(SkXfermode::kSrcOver_Mode),

- std::move(invalidBitmapSource),

- std::move(validBitmapSource), nullptr));

+ invalidBitmapSource.get(), validBitmapSource.get(), nullptr));

SkAutoTUnref<SkImageFilter> deserializedFilter(

TestFlattenableSerialization<SkImageFilter>(

« no previous file with comments | « tests/ImageFilterTest.cpp ('k') | no next file » | no next file with comments »