win: Remove GetModuleFromAddress, deduplicate __ImageBase code.

remoting/host/continue_window_win.cc

Index: remoting/host/continue_window_win.cc
diff --git a/remoting/host/continue_window_win.cc b/remoting/host/continue_window_win.cc
index 548d9280fce26bdce39604dc587eb089614dd3d1..d0ac25607b4727f2e629ef871798414fe4a1ae71 100644
--- a/remoting/host/continue_window_win.cc
+++ b/remoting/host/continue_window_win.cc
@@ -10,9 +10,9 @@
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/macros.h"
-#include "base/process/memory.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/win/current_module.h"
 #include "remoting/host/continue_window.h"
 #include "remoting/host/win/core_resource.h"
 
@@ -55,9 +55,8 @@ void ContinueWindowWin::ShowUi() {
   DCHECK(CalledOnValidThread());
   DCHECK(!hwnd_);
 
-  HMODULE instance = base::GetModuleFromAddress(&DialogProc);
-  hwnd_ = CreateDialogParam(instance, MAKEINTRESOURCE(IDD_CONTINUE), nullptr,
-                            (DLGPROC)DialogProc, (LPARAM)this);
+  hwnd_ = CreateDialogParam(CURRENT_MODULE(), MAKEINTRESOURCE(IDD_CONTINUE),
+                            nullptr, (DLGPROC)DialogProc, (LPARAM) this);

[joedow, 2016/04/04 15:37:01]

Why the extra space for 'this' and not in front of the other casts?

[Nico, 2016/04/04 15:43:07]

Excellent question. clang-format put it there, but that looks like a bug. Filed
https://llvm.org/bugs/show_bug.cgi?id=27198

   if (!hwnd_) {
     LOG(ERROR) << "Unable to create Disconnect dialog for remoting.";
     return;