Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: remoting/base/breakpad_win.cc

Issue 1852143002: win: Remove GetModuleFromAddress, deduplicate __ImageBase code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/base/breakpad_win.cc
diff --git a/remoting/base/breakpad_win.cc b/remoting/base/breakpad_win.cc
index ae1a81e058c71a1666caba259d334c496e13d1da..6ba02c5b43610def5a509680c1e497ba9930ff98 100644
--- a/remoting/base/breakpad_win.cc
+++ b/remoting/base/breakpad_win.cc
@@ -18,8 +18,8 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/scoped_ptr.h"
-#include "base/process/memory.h"
#include "base/strings/utf_string_conversions.h"
+#include "base/win/current_module.h"
#include "base/win/wrapped_window_proc.h"
#include "breakpad/src/client/windows/handler/exception_handler.h"
@@ -144,10 +144,8 @@ BreakpadWin* BreakpadWin::GetInstance() {
// Returns the Custom information to be used for crash reporting.
google_breakpad::CustomClientInfo* BreakpadWin::GetCustomInfo() {
- HMODULE binary = base::GetModuleFromAddress(
- reinterpret_cast<void*>(&remoting::InitializeCrashReporting));
scoped_ptr<FileVersionInfo> version_info(
- FileVersionInfo::CreateFileVersionInfoForModule(binary));
+ FileVersionInfo::CreateFileVersionInfoForModule(CURRENT_MODULE()));
static wchar_t version[64];
if (version_info.get()) {

Powered by Google App Engine
This is Rietveld 408576698