win: Remove GetModuleFromAddress, deduplicate __ImageBase code.

remoting/host/continue_window_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <windows.h>
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/compiler_specific.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/macros.h"
-#include "base/process/memory.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/win/current_module.h"
 #include "remoting/host/continue_window.h"
 #include "remoting/host/win/core_resource.h"
 
 namespace remoting {
 
 namespace {
 
 class ContinueWindowWin : public ContinueWindow {
  public:
   ContinueWindowWin();
@@ skipping 22 matching lines @@
 }
 
 ContinueWindowWin::~ContinueWindowWin() {
   EndDialog();
 }
 
 void ContinueWindowWin::ShowUi() {
   DCHECK(CalledOnValidThread());
   DCHECK(!hwnd_);
 
-  HMODULE instance = base::GetModuleFromAddress(&DialogProc);
-  hwnd_ = CreateDialogParam(instance, MAKEINTRESOURCE(IDD_CONTINUE), nullptr,
-                            (DLGPROC)DialogProc, (LPARAM)this);
+  hwnd_ = CreateDialogParam(CURRENT_MODULE(), MAKEINTRESOURCE(IDD_CONTINUE),
+                            nullptr, (DLGPROC)DialogProc, (LPARAM) this);

[joedow, 2016/04/04 15:37:01]

Why the extra space for 'this' and not in front of the other casts?

[Nico, 2016/04/04 15:43:07]

Excellent question. clang-format put it there, but that looks like a bug. Filed
https://llvm.org/bugs/show_bug.cgi?id=27198

   if (!hwnd_) {
     LOG(ERROR) << "Unable to create Disconnect dialog for remoting.";
     return;
   }
 
   ShowWindow(hwnd_, SW_SHOW);
 }
 
 void ContinueWindowWin::HideUi() {
   DCHECK(CalledOnValidThread());
@@ skipping 56 matching lines @@
 }
 
 }  // namespace
 
 // static
 scoped_ptr<HostWindow> HostWindow::CreateContinueWindow() {
   return make_scoped_ptr(new ContinueWindowWin());
 }
 
 }  // namespace remoting