tests/ImageFilterTest.cpp.rej - Issue 1852123002: Update SkXfermodeImageFilter to sk_sp

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tests/ImageFilterTest.cpp.rej

Issue 1852123002: Update SkXfermodeImageFilter to sk_sp (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Overload Make methods Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 *************** public:

	2 * 231,237 **

	3 cropRect ).release());

	4 }

	5 this->addFilter("xfermode", SkXfermodeImageFilter::Make(

	6 - SkXfermode::Make(SkXfermode::kSrc_Mode), input, input, cropRect).r elease());

	7 }

	8 int count() const { return fFilters.count(); }

	9 SkImageFilter* getFilter(int index) const { return fFilters[index].fFilter .get(); }

	10 --- 231,240 ----

	11 cropRect ).release());

	12 }

	13 this->addFilter("xfermode", SkXfermodeImageFilter::Make(

	14 + SkXfermode::Make(SkXfermode::kSrc_ Mode),

	15 + sk_ref_sp<SkImageFilter>(input),

	16 + sk_ref_sp<SkImageFilter>(input),

	17 + cropRect).release());

	18 }

	19 int count() const { return fFilters.count(); }

	20 SkImageFilter* getFilter(int index) const { return fFilters[index].fFilter .get(); }

OLD	NEW

« no previous file with comments | « tests/ImageFilterTest.cpp.orig ('k') | tests/SerializationTest.cpp » ('j') | no next file with comments »