build/gn_helpers.py - Issue 1851723002: Let gn_helpers.py handle unicode as str

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/gn_helpers.py

Issue 1851723002: Let gn_helpers.py handle unicode as str (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/gn_helpers.py

diff --git a/build/gn_helpers.py b/build/gn_helpers.py

index f1037720bbf878ac8cbaa56f0896aaec04ea5a62..6a61a0877f04e79ad200637515cf8efd245b711d 100644

--- a/build/gn_helpers.py

+++ b/build/gn_helpers.py

@@ -36,6 +36,9 @@ def ToGNString(value, allow_dicts = True):

value.replace('\\', '\\\\').replace('"', '\\"').replace('$', '\\$') + \

'"'

+ if isinstance(value, unicode):

+ return ToGNString(value.encode('utf-8'))

if isinstance(value, bool):

if value:

return "true"

« no previous file with comments | « no previous file | no next file » | no next file with comments »