[modules] Treat top-level functions as lexical

[modules] Treat top-level functions as lexical

[15.2.1.11 Static Semantics:
LexicallyDeclaredNames](https://tc39.github.io/ecma262/#sec-module-semantics-static-semantics-lexicallydeclarednames)
(in contrast with its definition for StatementListItem) makes no
explicit provision for HoistableDeclarations. This means that function
declarations are treated as lexically scoped in module code, as
described in section 15.2.1.11's informative note:

> At the top level of a function, or script, function declarations are
> treated like var declarations rather than like lexical declarations.

BUG=v8:4884
LOG=N
R=adamk@chromium.org

Committed: https://crrev.com/43fa3e65c931bc2a91a7e2be935ebbc4fb269b0d
Cr-Commit-Position: refs/heads/master@{#35633}

[adamk, 2016-04-04 22:19:54]

Thanks for the bug report and test!

https://codereview.chromium.org/1851673007/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1851673007/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1917: (declaration_scope->is_module_scope() &&
This code belongs not here, but in Parser::ParseFunctionDeclaration().

[mike3, 2016-04-13 21:18:44]

Hi Adam!

I've just re-implemented this change as you have requested. It doesn't seem as
though any new documentation is needed--the existing comment already describes
the intended behavior:

    // In ES6, a function behaves as a lexical binding, except in
    // a script scope, or the initial scope of eval or another function.

https://codereview.chromium.org/1851673007/diff/1/src/parsing/parser.cc
File src/parsing/parser.cc (right):

https://codereview.chromium.org/1851673007/diff/1/src/parsing/parser.cc#newco...
src/parsing/parser.cc:1917: (declaration_scope->is_module_scope() &&
On 2016/04/04 22:19:54, adamk wrote:
> This code belongs not here, but in Parser::ParseFunctionDeclaration().

Of course, that makes much more sense.

[adamk, 2016-04-18 18:27:23]

lgtm

[mike3, 2016-04-19 13:29:39]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2016-04-19 13:29:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851673007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851673007/20001

[commit-bot: I haz the power, 2016-04-19 15:32:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-19 15:32:45]

Try jobs failed on following builders:
  v8_linux_arm_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/377)
  v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on tryserver.v8 (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/4501)

[mike3, 2016-04-19 17:34:53]

The CQ bit was checked by mike@mikepennisi.com

[commit-bot: I haz the power, 2016-04-19 17:34:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1851673007/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1851673007/20001

[commit-bot: I haz the power, 2016-04-19 17:51:59]

Committed patchset #2 (id:20001)

[nodir1, 2016-04-22 18:43:16]

Description was changed from

==========
[modules] Treat top-level functions as lexical

[15.2.1.11 Static Semantics:
LexicallyDeclaredNames](https://tc39.github.io/ecma262/#sec-module-semantics-static-semantics-lexicallydeclarednames)
(in contrast with its definition for StatementListItem) makes no
explicit provision for HoistableDeclarations. This means that function
declarations are treated as lexically scoped in module code, as
described in section 15.2.1.11's informative note:

> At the top level of a function, or script, function declarations are
> treated like var declarations rather than like lexical declarations.

BUG=v8:4884
LOG=N
R=adamk@chromium.org
==========

to

==========
[modules] Treat top-level functions as lexical

[15.2.1.11 Static Semantics:
LexicallyDeclaredNames](https://tc39.github.io/ecma262/#sec-module-semantics-static-semantics-lexicallydeclarednames)
(in contrast with its definition for StatementListItem) makes no
explicit provision for HoistableDeclarations. This means that function
declarations are treated as lexically scoped in module code, as
described in section 15.2.1.11's informative note:

> At the top level of a function, or script, function declarations are
> treated like var declarations rather than like lexical declarations.

BUG=v8:4884
LOG=N
R=adamk@chromium.org

Committed: https://crrev.com/43fa3e65c931bc2a91a7e2be935ebbc4fb269b0d
Cr-Commit-Position: refs/heads/master@{#35633}
==========

[nodir1, 2016-04-22 18:43:17]

Patchset 2 (id:??) landed as
https://crrev.com/43fa3e65c931bc2a91a7e2be935ebbc4fb269b0d
Cr-Commit-Position: refs/heads/master@{#35633}