[modules] Treat top-level functions as lexical

src/parsing/parser.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/parsing/parser.h"
 
 #include "src/api.h"
 #include "src/ast/ast.h"
 #include "src/ast/ast-expression-rewriter.h"
 #include "src/ast/ast-expression-visitor.h"
@@ skipping 1892 matching lines @@
     var = declaration_scope->LookupLocal(name);
     if (var == NULL) {
       // Declare the name.
       Variable::Kind kind = Variable::NORMAL;
       if (is_function_declaration) {
         kind = Variable::FUNCTION;
       }
       var = declaration_scope->DeclareLocal(
           name, mode, declaration->initialization(), kind, kNotAssigned);
     } else if ((IsLexicalVariableMode(mode) ||
-                IsLexicalVariableMode(var->mode())) &&
+                IsLexicalVariableMode(var->mode()) ||
+                // At the top level of a Module, function declarations are
+                // treated like lexical declarations rather than like var
+                // declarations.
+                (declaration_scope->is_module_scope() &&

[adamk, 2016/04/04 22:19:54]

This code belongs not here, but in Parser::ParseFunctionDeclaration().

[mike3, 2016/04/13 21:18:44]

Of course, that makes much more sense.

+                 (is_function_declaration || var->is_function()))) &&
                // Lexical bindings may appear for some parameters in sloppy
                // mode even with --harmony-sloppy off.
                (is_strict(language_mode()) || allow_harmony_sloppy())) {
       // Allow duplicate function decls for web compat, see bug 4693.
       if (is_sloppy(language_mode()) && is_function_declaration &&
           var->is_function()) {
         DCHECK(IsLexicalVariableMode(mode) &&
                IsLexicalVariableMode(var->mode()));
         ++use_counts_[v8::Isolate::kSloppyModeBlockScopedFunctionRedefinition];
       } else {
@@ skipping 4936 matching lines @@
                         try_block, target);
     final_loop = target;
   }
 
   return final_loop;
 }
 
 
 }  // namespace internal
 }  // namespace v8