Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1147)

Unified Diff: third_party/WebKit/public/platform/WebPrivatePtr.h

Issue 1851293002: Remove BLINK_ASSERT() and BLINK_ASSERT_NOT_REACHED() macros. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check the |callbacks| for nullptr and use explicit delete. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebPrivatePtr.h
diff --git a/third_party/WebKit/public/platform/WebPrivatePtr.h b/third_party/WebKit/public/platform/WebPrivatePtr.h
index 047d32cecd3a77ed29fab882a117c9ed459e012e..724b0aeedf26e6779b713e3e96db0ed98c02e5b4 100644
--- a/third_party/WebKit/public/platform/WebPrivatePtr.h
+++ b/third_party/WebKit/public/platform/WebPrivatePtr.h
@@ -32,6 +32,7 @@
#define WebPrivatePtr_h
#include "WebCommon.h"
+#include "base/logging.h"
#if INSIDE_BLINK
#include "platform/heap/Handle.h"
@@ -248,7 +249,7 @@ public:
// want to expose destructors of core classes to embedders. We should
// call reset() manually in destructors of classes with WebPrivatePtr
// members.
- BLINK_ASSERT(!m_storage);
+ DCHECK(!m_storage);
}
bool isNull() const { return !m_storage; }
« no previous file with comments | « third_party/WebKit/public/platform/WebPrivateOwnPtr.h ('k') | third_party/WebKit/public/platform/WebProcessMemoryDump.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698