Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 1851093005: Remove content/child/npapi (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
Reviewers:
jam, dcheng
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_combined_01_02
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content/child/npapi BUG=493212 Committed: https://crrev.com/3e17a452377e8c2ecff50594cbf4c9e7c2d7abac Cr-Commit-Position: refs/heads/master@{#385033}

Patch Set 1 : . #

Patch Set 2 : . #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix analyse #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5108 lines) Patch
M content/child/BUILD.gn View 1 2 3 4 1 chunk +1 line, -40 lines 0 comments Download
D content/child/npapi/DEPS View 1 chunk +0 lines, -4 lines 0 comments Download
D content/child/npapi/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D content/child/npapi/np_channel_base.h View 1 chunk +0 lines, -151 lines 0 comments Download
D content/child/npapi/np_channel_base.cc View 1 chunk +0 lines, -281 lines 0 comments Download
D content/child/npapi/plugin_host.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/child/npapi/plugin_host.cc View 1 chunk +0 lines, -863 lines 0 comments Download
D content/child/npapi/plugin_instance.h View 1 chunk +0 lines, -274 lines 0 comments Download
D content/child/npapi/plugin_instance.cc View 1 chunk +0 lines, -407 lines 0 comments Download
D content/child/npapi/plugin_instance_mac.mm View 1 chunk +0 lines, -56 lines 0 comments Download
D content/child/npapi/plugin_lib.h View 1 chunk +0 lines, -135 lines 0 comments Download
D content/child/npapi/plugin_lib.cc View 1 chunk +0 lines, -333 lines 0 comments Download
D content/child/npapi/plugin_lib_unittest.cc View 1 chunk +0 lines, -64 lines 0 comments Download
D content/child/npapi/plugin_web_event_converter_mac.h View 1 chunk +0 lines, -55 lines 0 comments Download
D content/child/npapi/plugin_web_event_converter_mac.mm View 1 chunk +0 lines, -189 lines 0 comments Download
D content/child/npapi/webplugin.h View 1 chunk +0 lines, -84 lines 0 comments Download
D content/child/npapi/webplugin_accelerated_surface_mac.h View 1 chunk +0 lines, -39 lines 0 comments Download
D content/child/npapi/webplugin_delegate.h View 1 chunk +0 lines, -86 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -287 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl.cc View 1 chunk +0 lines, -203 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl_android.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl_aura.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl_mac.mm View 1 chunk +0 lines, -696 lines 0 comments Download
D content/child/npapi/webplugin_delegate_impl_win.cc View 1 chunk +0 lines, -369 lines 0 comments Download
D content/child/npapi/webplugin_resource_client.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/child/plugin_message_generator.h View 1 chunk +0 lines, -7 lines 0 comments Download
D content/child/plugin_message_generator.cc View 1 chunk +0 lines, -33 lines 0 comments Download
D content/child/plugin_messages.h View 1 chunk +0 lines, -183 lines 0 comments Download
M content/content_child.gypi View 3 chunks +0 lines, -39 lines 0 comments Download
M content/content_tests.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +0 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 25 (11 generated)
piman
jam: please review dcheng: content/child/plugin_messages.h and ipc/ipc_message_start.h This depends on both https://codereview.chromium.org/1852593004/ and https://codereview.chromium.org/1853793003/
4 years, 8 months ago (2016-04-02 00:00:05 UTC) #2
dcheng
ipc changes lgtm
4 years, 8 months ago (2016-04-02 00:06:23 UTC) #3
jam
lgtm
4 years, 8 months ago (2016-04-04 17:24:11 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093005/80001
4 years, 8 months ago (2016-04-04 19:21:32 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/89750)
4 years, 8 months ago (2016-04-04 19:27:18 UTC) #9
commit-bot: I haz the power
This CL has an open dependency (Issue 1853793003 Patch 50001). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-04 20:01:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093005/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093005/100001
4 years, 8 months ago (2016-04-04 20:43:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1851093005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1851093005/120001
4 years, 8 months ago (2016-04-04 21:09:59 UTC) #18
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 8 months ago (2016-04-04 22:36:49 UTC) #19
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/3e17a452377e8c2ecff50594cbf4c9e7c2d7abac Cr-Commit-Position: refs/heads/master@{#385033}
4 years, 8 months ago (2016-04-04 22:38:51 UTC) #21
Will Harris
∩༼˵☯‿☯˵༽つ¤=[]:::::> npapi
4 years, 8 months ago (2016-04-04 23:18:39 UTC) #22
Nico
Nice! This broke enable_ipc_fuzzer=1 builds: FAILED: ninja -t msvc -e environment.x86 -- "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo ...
4 years, 8 months ago (2016-04-05 14:38:31 UTC) #23
piman
On Tue, Apr 5, 2016 at 7:38 AM, <thakis@chromium.org> wrote: > Nice! > > This ...
4 years, 8 months ago (2016-04-05 15:20:10 UTC) #24
piman
4 years, 8 months ago (2016-04-05 17:39:48 UTC) #25
Message was sent while issue was closed.
On Tue, Apr 5, 2016 at 8:19 AM, Antoine Labour <piman@chromium.org> wrote:

>
>
> On Tue, Apr 5, 2016 at 7:38 AM, <thakis@chromium.org> wrote:
>
>> Nice!
>>
>> This broke enable_ipc_fuzzer=1 builds:
>>
>> FAILED: ninja -t msvc -e environment.x86 --
>> "..\..\third_party/llvm-build/Release+Asserts/bin/clang-cl" -m32 /nologo
>> /showIncludes /FC
>> @obj\tools\ipc_fuzzer\message_lib\ipc_message_lib.message_names.obj.rsp /c
>> ..\..\tools\ipc_fuzzer\message_lib\message_names.cc
>> /Foobj\tools\ipc_fuzzer\message_lib\ipc_message_lib.message_names.obj
>> /Fdobj\tools\ipc_fuzzer\message_lib\ipc_message_lib.cc.pdb
>> In file included from
>> ..\..\tools\ipc_fuzzer\message_lib\message_names.cc:6:
>> ..\..\tools/ipc_fuzzer/message_lib/all_messages.h(27,10): fatal error:
>> 'content/child/plugin_message_generator.h' file not found
>> #include "content/child/plugin_message_generator.h"
>> ^
>>
>>
>>
https://build.chromium.org/p/chromium.fyi/builders/CrWinAsan/builds/3226/step...
>>
>> I guess there's more code to be delete there? Can you take a look?
>>
>
> Sorry about that. I will take a look.
>

https://codereview.chromium.org/1864583002/ should take care of it.


>
> Antoine
>
>
>>
>> https://codereview.chromium.org/1851093005/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698