Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1856963002: Remove content/public/plugin and chrome/plugin (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, kalyank, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_03_content_child_npapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content/public/plugin and chrome/plugin This is not needed anymore now that NPAPI is gone. BUG=493212 Committed: https://crrev.com/72dcbed943cbd6285d940adcf5c53076475e1917 Cr-Commit-Position: refs/heads/master@{#385102}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -264 lines) Patch
M ash/shell/content/client/shell_main_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/chrome.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/chrome_plugin.gypi View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/plugin/BUILD.gn View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/plugin/DEPS View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/plugin/chrome_content_plugin_client.h View 1 chunk +0 lines, -15 lines 0 comments Download
D chrome/plugin/chrome_content_plugin_client.cc View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/test/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M content/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/app/content_main_runner.cc View 3 chunks +3 lines, -13 lines 0 comments Download
D content/content_plugin.gypi View 1 chunk +0 lines, -46 lines 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/ppapi_plugin/BUILD.gn View 2 chunks +5 lines, -1 line 0 comments Download
M content/ppapi_plugin/DEPS View 1 chunk +2 lines, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_plugin_main.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M content/public/app/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/app/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/app/content_main_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/app/content_main_delegate.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M content/public/common/content_client.h View 3 chunks +0 lines, -4 lines 0 comments Download
M content/public/common/content_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D content/public/plugin/BUILD.gn View 1 chunk +0 lines, -30 lines 0 comments Download
D content/public/plugin/content_plugin_client.h View 1 chunk +0 lines, -28 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (5 generated)
piman
jam: please review sky: ash/shell/content/client/shell_main_delegate.h jochen: new gin dependency (moves from chrome/plugin to content/pepper_plugin; content/child ...
4 years, 8 months ago (2016-04-04 20:37:48 UTC) #2
jam
lgtm
4 years, 8 months ago (2016-04-04 21:15:36 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856963002/20001
4 years, 8 months ago (2016-04-04 21:26:15 UTC) #5
sky
ash LGTM
4 years, 8 months ago (2016-04-04 22:47:35 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-05 00:26:36 UTC) #8
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-05 03:50:21 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1856963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1856963002/20001
4 years, 8 months ago (2016-04-05 04:20:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 04:27:30 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 04:28:40 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72dcbed943cbd6285d940adcf5c53076475e1917
Cr-Commit-Position: refs/heads/master@{#385102}

Powered by Google App Engine
This is Rietveld 408576698