Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1860753002: Remove third_party/npapi (Closed)

Created:
4 years, 8 months ago by piman
Modified:
4 years, 8 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dcheng, dglazkov+blink, extensions-reviews_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@remove_03_content_child_npapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove third_party/npapi BUG=493212 Committed: https://crrev.com/5e38cc0507da608e31a488d40a9293cb4a2428c6 Cr-Commit-Position: refs/heads/master@{#385135}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase on top of https://codereview.chromium.org/1858893002/ #

Patch Set 3 : actually remove message handlers #

Patch Set 4 : messed up previous upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3038 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M content/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/font_utils_linux.cc View 3 chunks +20 lines, -20 lines 0 comments Download
M content/browser/renderer_host/sandbox_ipc_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_renderer.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/core.gyp View 7 chunks +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/web.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/npapi/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/npapi/LICENSE View 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/npapi/README.chromium View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/npapi/bindings/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/npapi/bindings/npapi.h View 1 chunk +0 lines, -921 lines 0 comments Download
D third_party/npapi/bindings/npapi_extensions.h View 1 chunk +0 lines, -1079 lines 0 comments Download
D third_party/npapi/bindings/npapi_extensions_private.h View 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/npapi/bindings/npapi_x11.h View 1 chunk +0 lines, -62 lines 0 comments Download
D third_party/npapi/bindings/npfunctions.h View 1 chunk +0 lines, -239 lines 0 comments Download
D third_party/npapi/bindings/nphostapi.h View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/npapi/bindings/npruntime.h View 1 chunk +0 lines, -397 lines 0 comments Download
D third_party/npapi/bindings/nptypes.h View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/npapi/npapi.gyp View 1 chunk +0 lines, -37 lines 0 comments Download

Depends on Patchset:

Issue 1858893002 Patch 1

Messages

Total messages: 25 (13 generated)
piman
https://codereview.chromium.org/1860753002/diff/1/content/browser/renderer_host/font_utils_linux.cc File content/browser/renderer_host/font_utils_linux.cc (right): https://codereview.chromium.org/1860753002/diff/1/content/browser/renderer_host/font_utils_linux.cc#newcode44 content/browser/renderer_host/font_utils_linux.cc:44: case PP_PRIVATEFONTCHARSET_ANSI: The PPAPI enum has the same values ...
4 years, 8 months ago (2016-04-04 21:30:42 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860753002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860753002/1
4 years, 8 months ago (2016-04-04 21:31:56 UTC) #4
piman
dcheng already queued a CL to remove WebBindings (https://codereview.chromium.org/1858893002/), so I rebased on top of ...
4 years, 8 months ago (2016-04-04 23:19:49 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 1858893002 Patch 1). Please resolve the dependency and ...
4 years, 8 months ago (2016-04-05 00:38:29 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860753002/60001
4 years, 8 months ago (2016-04-05 00:40:43 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/199347)
4 years, 8 months ago (2016-04-05 02:21:08 UTC) #14
jochen (gone - plz use gerrit)
lgtm
4 years, 8 months ago (2016-04-05 03:47:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860753002/60001
4 years, 8 months ago (2016-04-05 04:21:11 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/48211)
4 years, 8 months ago (2016-04-05 06:44:57 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1860753002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1860753002/60001
4 years, 8 months ago (2016-04-05 07:41:19 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-05 08:59:24 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 09:00:59 UTC) #25
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5e38cc0507da608e31a488d40a9293cb4a2428c6
Cr-Commit-Position: refs/heads/master@{#385135}

Powered by Google App Engine
This is Rietveld 408576698