net/url_request/certificate_report_sender_unittest.cc - Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/certificate_report_sender_unittest.cc

Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix null dereference Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/certificate_report_sender.h ('K') | « net/url_request/certificate_report_sender.cc ('k') | net/url_request/url_request_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/certificate_report_sender_unittest.cc

diff --git a/net/url_request/certificate_report_sender_unittest.cc b/net/url_request/certificate_report_sender_unittest.cc

index 8cf7a9162e1d34eb783c1d670ec06d901b0de92d..3cc57a38f79f79ca0a61b6a144edff7373a2da43 100644

--- a/net/url_request/certificate_report_sender_unittest.cc

+++ b/net/url_request/certificate_report_sender_unittest.cc

@@ -49,8 +49,8 @@ void CheckUploadData(const URLRequest& request,

// Provides an error callback for report sending. If the callback is

// called, it sets |called| to true.

eroman 2016/04/02 01:55:25 Maybe rephrase this comment to just saying it sets

estark 2016/04/05 00:57:30 Done.

-void ErrorCallback(bool* called, URLRequest* request) {

- EXPECT_FALSE(request->status().is_success());

+void ErrorCallback(bool* called, GURL report_uri, int net_error) {

+ EXPECT_NE(OK, net_error);

*called = true;

}