Use CertificateReportSender error callback to record HPKP UMA metrics

net/url_request/certificate_report_sender_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/url_request/certificate_report_sender.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/macros.h"
 #include "base/run_loop.h"
@@ skipping 30 matching lines @@
 
   const UploadBytesElementReader* reader =
       (*upload->GetElementReaders())[0]->AsBytesReader();
   ASSERT_TRUE(reader);
   std::string upload_data(reader->bytes(), reader->length());
 
   EXPECT_EQ(1u, expect_reports->erase(upload_data));
 }
 
 // Provides an error callback for report sending. If the callback is
 // called, it sets |called| to true.

[eroman, 2016/04/02 01:55:25]

Maybe rephrase this comment to just saying it sets *called to true.

[estark, 2016/04/05 00:57:30]

Done.

-void ErrorCallback(bool* called, URLRequest* request) {
-  EXPECT_FALSE(request->status().is_success());
+void ErrorCallback(bool* called, GURL report_uri, int net_error) {
+  EXPECT_NE(OK, net_error);
   *called = true;
 }
 
 // A network delegate that lets tests check that a certificate report
 // was sent. It counts the number of requests and lets tests register a
 // callback to run when the request is destroyed. It also checks that
 // the uploaded data is as expected.
 class TestCertificateReportSenderNetworkDelegate : public NetworkDelegateImpl {
  public:
   TestCertificateReportSenderNetworkDelegate()
@@ skipping 222 matching lines @@
   GURL url = URLRequestMockDataJob::GetMockHttpsUrl("dummy data", 1);
   CertificateReportSender reporter(
       context(), CertificateReportSender::DO_NOT_SEND_COOKIES);
 
   network_delegate_.set_expect_cookies(false);
   SendReport(&reporter, kDummyReport, url, 0);
 }
 
 }  // namespace
 }  // namespace net