net/url_request/url_request_unittest.cc - Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_unittest.cc

Issue 1850853004: Use CertificateReportSender error callback to record HPKP UMA metrics (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix null dereference Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/url_request/certificate_report_sender_unittest.cc ('K') | « net/url_request/certificate_report_sender_unittest.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/url_request/url_request_unittest.cc

diff --git a/net/url_request/url_request_unittest.cc b/net/url_request/url_request_unittest.cc

index 5c82c9a08cc79d6259c2f2d955104bc4b518008c..7de21f8ec47fd042813b92209474b322bc0e906d 100644

--- a/net/url_request/url_request_unittest.cc

+++ b/net/url_request/url_request_unittest.cc

@@ -689,6 +689,9 @@ class MockCertificateReportSender

latest_report_ = report;

}

+ void SetErrorCallback(

+ const base::Callback<void(GURL, int)>& error_callback) override {}

const GURL& latest_report_uri() { return latest_report_uri_; }

const std::string& latest_report() { return latest_report_; }