cc : Fix bug in tree synchronization when mask layer changes

cc :  Fix bug in tree synchronization when mask layer changes

This CL also moves an out-of-place DCHECK.

BUG=598875
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/11cb9635daf8326b02a752f51f92785dc6c220f2
Cr-Commit-Position: refs/heads/master@{#384160}

[jaydasika, 2016-03-30 18:31:17]

Description was changed from

==========
cc :  Fix bug in tree synchronization when mask layer changes

This CL also moves an out-of-place DCHECK.

BUG=598875
==========

to

==========
cc :  Fix bug in tree synchronization when mask layer changes

This CL also moves an out-of-place DCHECK.

BUG=598875
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[jaydasika, 2016-03-30 18:35:20]

jaydasika@chromium.org changed reviewers:
+ ajuma@chromium.org, enne@chromium.org, weiliangc@chromium.org

[jaydasika, 2016-03-30 18:35:21]

PTAL

[ajuma, 2016-03-30 21:50:59]

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:828:
SINGLE_THREAD_TEST_F(LayerTreeHostTestSwitchMaskLayer);
Any reason for this to be single-thread only? (If we change references to
active_tree to sync_tree, does the test still work multi-threaded?)

[danakj, 2016-03-30 22:13:35]

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:828:
SINGLE_THREAD_TEST_F(LayerTreeHostTestSwitchMaskLayer);
On 2016/03/30 21:50:59, ajuma wrote:
> Any reason for this to be single-thread only? (If we change references to
> active_tree to sync_tree, does the test still work multi-threaded?)

Thanks for asking this, would also appreciate a comment on top of the macro
explaining why, we should have this on every test that diverges from
MULTI_AND_SINGLE.

[jaydasika, 2016-03-30 22:33:34]

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1850453002/diff/20001/cc/trees/layer_tree_hos...
cc/trees/layer_tree_host_unittest.cc:828:
SINGLE_THREAD_TEST_F(LayerTreeHostTestSwitchMaskLayer);
On 2016/03/30 22:13:35, danakj wrote:
> On 2016/03/30 21:50:59, ajuma wrote:
> > Any reason for this to be single-thread only? (If we change references to
> > active_tree to sync_tree, does the test still work multi-threaded?)
> 
> Thanks for asking this, would also appreciate a comment on top of the macro
> explaining why, we should have this on every test that diverges from
> MULTI_AND_SINGLE.

Changed it to single and multi thread.

[ajuma, 2016-03-30 22:56:52]

Thanks, lgtm.

[jaydasika, 2016-03-30 22:57:18]

The CQ bit was checked by jaydasika@chromium.org

[commit-bot: I haz the power, 2016-03-30 22:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850453002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850453002/60001

[commit-bot: I haz the power, 2016-03-31 00:37:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-03-31 00:39:15]

Description was changed from

==========
cc :  Fix bug in tree synchronization when mask layer changes

This CL also moves an out-of-place DCHECK.

BUG=598875
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
cc :  Fix bug in tree synchronization when mask layer changes

This CL also moves an out-of-place DCHECK.

BUG=598875
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/11cb9635daf8326b02a752f51f92785dc6c220f2
Cr-Commit-Position: refs/heads/master@{#384160}
==========

[commit-bot: I haz the power, 2016-03-31 00:39:16]

Patchset 4 (id:??) landed as
https://crrev.com/11cb9635daf8326b02a752f51f92785dc6c220f2
Cr-Commit-Position: refs/heads/master@{#384160}