cc : Fix bug in tree synchronization when mask layer changes

cc/trees/layer_tree_host_unittest.cc

 // Copyright 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/trees/layer_tree_host.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>
@@ skipping 762 matching lines @@
         break;
     }
   }
 
   void AfterTest() override {}
   int index_;
 };
 
 SINGLE_THREAD_TEST_F(LayerTreeHostTestPropertyTreesChangedSync);
 
+class LayerTreeHostTestSwitchMaskLayer : public LayerTreeHostTest {
+ protected:
+  void SetupTree() override {
+    scoped_refptr<Layer> root = Layer::Create();
+    scoped_refptr<Layer> child = Layer::Create();
+    mask_layer = Layer::Create();
+    child->SetMaskLayer(mask_layer.get());
+    root->AddChild(std::move(child));
+    layer_tree_host()->SetRootLayer(root);
+    LayerTreeHostTest::SetupTree();
+  }
+
+  void BeginTest() override {
+    index_ = 0;
+    PostSetNeedsCommitToMainThread();
+  }
+
+  void DidCommit() override {
+    switch (layer_tree_host()->source_frame_number()) {
+      case 1:
+        layer_tree_host()->root_layer()->RemoveAllChildren();
+        layer_tree_host()->root_layer()->SetMaskLayer(mask_layer.get());
+        break;
+    }
+  }
+
+  void CommitCompleteOnThread(LayerTreeHostImpl* impl) override {
+    switch (index_) {
+      case 0:
+        index_++;
+        EXPECT_FALSE(impl->active_tree()->root_layer()->mask_layer());
+        break;
+      case 1:
+        EXPECT_TRUE(impl->active_tree()->root_layer()->mask_layer());
+        EndTest();
+        break;
+    }
+  }
+
+  void AfterTest() override {}
+
+  scoped_refptr<Layer> mask_layer;
+  int index_;
+};
+
+SINGLE_THREAD_TEST_F(LayerTreeHostTestSwitchMaskLayer);

[ajuma, 2016/03/30 21:50:59]

Any reason for this to be single-thread only? (If we change references to
active_tree to sync_tree, does the test still work multi-threaded?)

[danakj, 2016/03/30 22:13:35]

Thanks for asking this, would also appreciate a comment on top of the macro
explaining why, we should have this on every test that diverges from
MULTI_AND_SINGLE.

[jaydasika, 2016/03/30 22:33:34]

Changed it to single and multi thread.

+
 // 1 setNeedsRedraw after the first commit has completed should lead to 1
 // additional draw.
 class LayerTreeHostTestSetNeedsRedraw : public LayerTreeHostTest {
  public:
   LayerTreeHostTestSetNeedsRedraw() : num_commits_(0), num_draws_(0) {}
 
   void BeginTest() override { PostSetNeedsCommitToMainThread(); }
 
   void DrawLayersOnThread(LayerTreeHostImpl* impl) override {
     EXPECT_EQ(0, impl->active_tree()->source_frame_number());
@@ skipping 5887 matching lines @@
     EndTest();
   }
 
   void AfterTest() override {}
 };
 
 SINGLE_AND_MULTI_THREAD_TEST_F(LayerTreeHostTestPaintedDeviceScaleFactor);
 
 }  // namespace
 }  // namespace cc