cc/layers/layer.cc - Issue 1850453002: cc : Fix bug in tree synchronization when mask layer changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/layer.cc

Issue 1850453002: cc : Fix bug in tree synchronization when mask layer changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comments Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/layer.cc

diff --git a/cc/layers/layer.cc b/cc/layers/layer.cc

index 838a62d7648beed630d47422d9ce1f9b14999512..60dd6b1680fa07ece93049152d2162da5aafd209 100644

--- a/cc/layers/layer.cc

+++ b/cc/layers/layer.cc

@@ -413,8 +413,8 @@ void Layer::SetMaskLayer(Layer* mask_layer) {

}

mask_layer_ = mask_layer;

if (mask_layer_.get()) {

- DCHECK(!mask_layer_->parent());

mask_layer_->RemoveFromParent();

+ DCHECK(!mask_layer_->parent());

mask_layer_->SetParent(this);

mask_layer_->SetIsMask(true);

}

« no previous file with comments | « no previous file | cc/layers/layer_impl.h » ('j') | no next file with comments »