Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Issue 1850153002: Make top-layer elements work also when the viewport is paginated. (Closed)

Created:
4 years, 8 months ago by mstensho (USE GERRIT)
Modified:
4 years, 8 months ago
Reviewers:
chrishtr, Xianzhu
CC:
chromium-reviews, blink-reviews, mstensho (USE GERRIT), dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make top-layer elements work also when the viewport is paginated. When the viewport is paginated (by overflow:-webkit-paged-* specified on HTML or BODY), top-layer elements are redirected to a flow thread, along with everything else. So we have to go through the children of the flow thread, not the children of the layout view, when looking for them. BUG=594306 Committed: https://crrev.com/5233aa994b11d17c287311089234f58dbbead280 Cr-Commit-Position: refs/heads/master@{#385883}

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/pagination/modal-dialog.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html View 1 1 chunk +19 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-expected.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-01 12:17:23 UTC) #2
mstensho (USE GERRIT)
4 years, 8 months ago (2016-04-07 07:40:21 UTC) #5
Xianzhu
https://codereview.chromium.org/1850153002/diff/1/third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html File third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html (right): https://codereview.chromium.org/1850153002/diff/1/third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html#newcode23 third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html:23: setTimeout(paginateAllTheThings, 500); Can you use runAfterLayoutAndPaint() (../../resources/run-after-layout-and-paint.js) instead of ...
4 years, 8 months ago (2016-04-07 16:43:36 UTC) #6
mstensho (USE GERRIT)
https://codereview.chromium.org/1850153002/diff/1/third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html File third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html (right): https://codereview.chromium.org/1850153002/diff/1/third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html#newcode23 third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html:23: setTimeout(paginateAllTheThings, 500); On 2016/04/07 16:43:36, Xianzhu wrote: > Can ...
4 years, 8 months ago (2016-04-07 18:43:18 UTC) #7
Xianzhu
lgtm
4 years, 8 months ago (2016-04-07 19:00:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850153002/20001
4 years, 8 months ago (2016-04-07 19:00:36 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/193232)
4 years, 8 months ago (2016-04-07 20:17:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1850153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1850153002/20001
4 years, 8 months ago (2016-04-07 20:20:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 21:40:41 UTC) #16
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:43:04 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5233aa994b11d17c287311089234f58dbbead280
Cr-Commit-Position: refs/heads/master@{#385883}

Powered by Google App Engine
This is Rietveld 408576698