third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html - Issue 1850153002: Make top-layer elements work also when the viewport is paginated.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash.html

Issue 1850153002: Make top-layer elements work also when the viewport is paginated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/pagination/modal-dialog.html ('k') | third_party/WebKit/LayoutTests/fast/pagination/modal-dialog-crash-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <p>PASS if no crash or assertion failure.</p>

	3 <dialog id="dialog">

	4 <div id="dialogChild">

	5 <div style="transform:rotatey(0deg);"></div>

	6 <div style="position:absolute;"></div>

	7 </div>

	8 </dialog>

	9 <script>

	10 if (window.testRunner)

	11 testRunner.dumpAsText();

	12 function paginateAllTheThings() {

	13 document.body.style.overflowY = "-webkit-paged-x";

	14 document.getElementById("dialog").style.overflowY = "-webkit-paged-x";

	15 document.getElementById("dialogChild").style.overflowY = "-webkit-paged- x";

	16 }

	17 document.getElementById("dialog").showModal();

	18 if (window.internals) {

	19 internals.forceCompositingUpdate(document);

	20 paginateAllTheThings();

	21 } else {

	22 // Need a short delay, probably so that things get painted as they are b efore making more changes.

	23 setTimeout(paginateAllTheThings, 500);
	Xianzhu 2016/04/07 16:43:36 Can you use runAfterLayoutAndPaint() (../../resour Can you use runAfterLayoutAndPaint() (../../resources/run-after-layout-and-paint.js) instead of setTimeout? mstensho (USE GERRIT) 2016/04/07 18:43:18 Done. Show quoted text On 2016/04/07 16:43:36, Xianzhu wrote: > Can you use runAfterLayoutAndPaint() > (../../resources/run-after-layout-and-paint.js) instead of setTimeout? Done.
	24 }

	25 </script>

OLD	NEW