Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364
Committed: https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab
Cr-Commit-Position: refs/heads/master@{#384526}

[Takashi Toyoshima, 2016-04-01 07:20:58]

Description was changed from

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

BUG=599364
==========

to

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

BUG=599364
==========

[Takashi Toyoshima, 2016-04-01 07:20:58]

toyoshim@chromium.org changed reviewers:
+ jochen@chromium.org

[Takashi Toyoshima, 2016-04-01 07:22:31]

Jochen, can you take a look?
I split this one mechanical change from
https://codereview.chromium.org/1846653004/.

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorPageAgent.h (right):

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorPageAgent.h:103: //
TODO(crbug.com/599364): Rename |ignoreCache| to |bypassCache|.
I'd handle Inspector related changes separately.

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/testing/Internals.h (right):

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/testing/Internals.h:307: void forceReload(bool
bypassCache);
Probably it's reasonable to keep this bool.

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebFrameLoadType.h (left):

https://codereview.chromium.org/1850123002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebFrameLoadType.h:22: ReloadFromOrigin, // reload
bypassing cache
yeah, this comment was a bad signal actually.

[Takashi Toyoshima, 2016-04-01 07:22:39]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 07:22:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850123002/1

[Takashi Toyoshima, 2016-04-01 07:25:33]

Description was changed from

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

BUG=599364
==========

to

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364
==========

[jochen (gone - plz use gerrit), 2016-04-01 08:36:56]

lgtm

[commit-bot: I haz the power, 2016-04-01 09:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 09:00:49]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-04-01 09:07:44]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-04-01 09:07:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1850123002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1850123002/1

[commit-bot: I haz the power, 2016-04-01 09:13:16]

Description was changed from

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364
==========

to

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364
==========

[commit-bot: I haz the power, 2016-04-01 09:13:17]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-04-01 09:14:29]

Description was changed from

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364
==========

to

==========
Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG=599364

Committed: https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab
Cr-Commit-Position: refs/heads/master@{#384526}
==========

[commit-bot: I haz the power, 2016-04-01 09:14:30]

Patchset 1 (id:??) landed as
https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab
Cr-Commit-Position: refs/heads/master@{#384526}