Change bool ignoreCache to WebFrameLoadType

Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364
Committed: https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab
Cr-Commit-Position: refs/heads/master@{#384860}

[Takashi Toyoshima, 2016-03-31 09:38:30]

toyoshim@chromium.org changed reviewers:
+ jochen@chromium.org

[Takashi Toyoshima, 2016-03-31 09:38:31]

Can you review this too?

[Takashi Toyoshima, 2016-03-31 09:40:59]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-31 09:41:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843663005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843663005/1

[commit-bot: I haz the power, 2016-03-31 10:56:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-31 10:56:40]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-03-31 11:12:35]

Description was changed from

==========
Rename ignoreCache to bypassCache

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

This change rename ignoreCache to bypassCache to be consistent with
other flags.

This seris of changes remove 'ignore' or 'ignoring' from the code base
completely, and use 'validate' and 'bypass' to be consistent with
net flags.

In this change, I do not touch Inspector related code that also uses
'ignoreCache', but separately start discussion with Inspector team.

BUG=599364
==========

to

==========
Rename ignoreCache to bypassCache

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

This change rename ignoreCache to bypassCache to be consistent with
other flags.

This seris of changes remove 'ignore' or 'ignoring' from the code base
completely, and use 'validate' and 'bypass' to be consistent with
net flags.

In this change, I do not touch Inspector related code that also uses
'ignoreCache', but separately start discussion with Inspector team.

BUG=599364
==========

[jochen (gone - plz use gerrit), 2016-03-31 15:28:20]

if you touch those anyways, can we replace the bool with an enum please?

[Takashi Toyoshima, 2016-04-01 06:37:24]

Agreed. I'm rewriting this change to reuse WebFrameLoadType to specify reload
type because RemoteFrameClientImpl already use it internally and we eventually
remove reload() API.

[Takashi Toyoshima, 2016-04-01 10:20:03]

Description was changed from

==========
Rename ignoreCache to bypassCache

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

This change rename ignoreCache to bypassCache to be consistent with
other flags.

This seris of changes remove 'ignore' or 'ignoring' from the code base
completely, and use 'validate' and 'bypass' to be consistent with
net flags.

In this change, I do not touch Inspector related code that also uses
'ignoreCache', but separately start discussion with Inspector team.

BUG=599364
==========

to

==========
Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364
==========

[Takashi Toyoshima, 2016-04-01 10:26:33]

The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 10:26:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843663005/20001

[commit-bot: I haz the power, 2016-04-01 11:45:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 11:45:22]

Dry run: This issue passed the CQ dry run.

[Takashi Toyoshima, 2016-04-01 11:46:44]

PTAL

[jochen (gone - plz use gerrit), 2016-04-03 11:18:33]

lgtm

[Takashi Toyoshima, 2016-04-04 03:26:38]

The CQ bit was checked by toyoshim@chromium.org

[commit-bot: I haz the power, 2016-04-04 03:26:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843663005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843663005/20001

[commit-bot: I haz the power, 2016-04-04 03:28:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 03:28:58]

Try jobs failed on following builders:
  ios_dbg_simulator_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Takashi Toyoshima, 2016-04-04 06:06:08]

The CQ bit was checked by toyoshim@chromium.org

[Takashi Toyoshima, 2016-04-04 06:06:09]

The patchset sent to the CQ was uploaded after l-g-t-m from jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/1843663005/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-04-04 06:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1843663005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1843663005/40001

[commit-bot: I haz the power, 2016-04-04 07:17:42]

Description was changed from

==========
Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364
==========

to

==========
Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364
==========

[commit-bot: I haz the power, 2016-04-04 07:17:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-04 07:19:02]

Description was changed from

==========
Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364
==========

to

==========
Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG=599364

Committed: https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab
Cr-Commit-Position: refs/heads/master@{#384860}
==========

[commit-bot: I haz the power, 2016-04-04 07:19:03]

Patchset 3 (id:??) landed as
https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab
Cr-Commit-Position: refs/heads/master@{#384860}