Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: third_party/WebKit/Source/core/loader/FrameLoader.cpp

Issue 1850123002: Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/loader/FrameLoader.cpp
diff --git a/third_party/WebKit/Source/core/loader/FrameLoader.cpp b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
index 182c91b8f6eeb9a57fdf03e7e116ecee12900989..a169c6e1cc4012bbff853ed616f50ff269275c7e 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoader.cpp
+++ b/third_party/WebKit/Source/core/loader/FrameLoader.cpp
@@ -111,7 +111,7 @@ bool isBackForwardLoadType(FrameLoadType type)
static bool needsHistoryItemRestore(FrameLoadType type)
{
return type == FrameLoadTypeBackForward || type == FrameLoadTypeReload
- || type == FrameLoadTypeReloadFromOrigin;
+ || type == FrameLoadTypeReloadBypassingCache;
}
// static
@@ -135,8 +135,8 @@ ResourceRequest FrameLoader::resourceRequestFromHistoryItem(HistoryItem* item,
ResourceRequest FrameLoader::resourceRequestForReload(FrameLoadType frameLoadType,
const KURL& overrideURL, ClientRedirectPolicy clientRedirectPolicy)
{
- ASSERT(frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadFromOrigin);
- ResourceRequestCachePolicy cachePolicy = frameLoadType == FrameLoadTypeReloadFromOrigin ? BypassingCache : ValidatingCacheData;
+ ASSERT(frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadBypassingCache);
+ ResourceRequestCachePolicy cachePolicy = frameLoadType == FrameLoadTypeReloadBypassingCache ? BypassingCache : ValidatingCacheData;
if (!m_currentItem)
return ResourceRequest();
ResourceRequest request = resourceRequestFromHistoryItem(m_currentItem.get(), cachePolicy);
@@ -156,7 +156,7 @@ ResourceRequest FrameLoader::resourceRequestForReload(FrameLoadType frameLoadTyp
request.setURL(overrideURL);
request.clearHTTPReferrer();
}
- request.setSkipServiceWorker(frameLoadType == FrameLoadTypeReloadFromOrigin);
+ request.setSkipServiceWorker(frameLoadType == FrameLoadTypeReloadBypassingCache);
return request;
}
@@ -776,7 +776,7 @@ FrameLoadType FrameLoader::determineFrameLoadType(const FrameLoadRequest& reques
if (request.resourceRequest().getCachePolicy() == ValidatingCacheData)
return FrameLoadTypeReload;
if (request.resourceRequest().getCachePolicy() == BypassingCache)
- return FrameLoadTypeReloadFromOrigin;
+ return FrameLoadTypeReloadBypassingCache;
// From the HTML5 spec for location.assign():
// "If the browsing context's session history contains only one Document,
// and that was the about:blank Document created when the browsing context
@@ -828,7 +828,7 @@ static bool shouldOpenInNewWindow(Frame* targetFrame, const FrameLoadRequest& re
static NavigationType determineNavigationType(FrameLoadType frameLoadType, bool isFormSubmission, bool haveEvent)
{
- bool isReload = frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadFromOrigin;
+ bool isReload = frameLoadType == FrameLoadTypeReload || frameLoadType == FrameLoadTypeReloadBypassingCache;
bool isBackForward = isBackForwardLoadType(frameLoadType);
if (isFormSubmission)
return (isReload || isBackForward) ? NavigationTypeFormResubmitted : NavigationTypeFormSubmitted;
@@ -1271,7 +1271,7 @@ bool FrameLoader::shouldPerformFragmentNavigation(bool isFormSubmission, const S
// currently displaying a frameset, or if the URL does not have a fragment.
return (!isFormSubmission || equalIgnoringCase(httpMethod, HTTPNames::GET))
&& loadType != FrameLoadTypeReload
- && loadType != FrameLoadTypeReloadFromOrigin
+ && loadType != FrameLoadTypeReloadBypassingCache
&& loadType != FrameLoadTypeSame
&& loadType != FrameLoadTypeBackForward
&& url.hasFragmentIdentifier()

Powered by Google App Engine
This is Rietveld 408576698