Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184993005: Rename ChromiumTestShell classes to ChromeShell. (Closed)

Created:
6 years, 9 months ago by aurimas (slooooooooow)
Modified:
6 years, 9 months ago
Reviewers:
craigdh, nyquist, tonyg, pfeldman
CC:
chromium-reviews, tburkard+watch_chromium.org, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, aandrey+blink_chromium.org, Ilya Sherman, frankf+watch_chromium.org, tim+watch_chromium.org, craigdh+watch_chromium.org, vsevik, benquan, yfriedman+watch_chromium.org, devtools-reviews_chromium.org, erikwright+watch_chromium.org, haitaol+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, paulirish+reviews_chromium.org, bulach+watch_chromium.org, ilevy-cc_chromium.org, stgao, rouslan+autofillwatch_chromium.org, maniscalco+watch_chromium.org, davidben+watch_chromium.org, frankf, yurys, dominich+watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, klundberg+watch_chromium.org, pfeldman, telemetry+watch_chromium.org
Visibility:
Public.

Description

Rename ChromiumTestShell classes to ChromeShell. Renaming ChromiumTestShell* classes to ChromeShell*. This CL depends on https://chromiumcodereview.appspot.com/184493006/ BUG=348137 NOTRY=true TBR=pfeldman,tonyg,craigdh Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255073

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Patch Set 9 : Rebase yet again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -868 lines) Patch
base/android/java/src/org/chromium/base/CommandLine.java View 1 chunk +1 line, -1 line 0 comments Download
build/android/adb_gdb_chromium_testshell View 1 chunk +1 line, -1 line 0 comments Download
build/android/adb_run_chromium_testshell View 1 chunk +1 line, -1 line 0 comments Download
build/android/findbugs_filter/findbugs_exclude.xml View 1 chunk +1 line, -1 line 0 comments Download
build/android/pylib/constants.py View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 1 chunk +1 line, -1 line 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java View 2 chunks +5 lines, -5 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/RepostFormWarningTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/ShortcutHelperTest.java View 3 chunks +10 lines, -10 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/autofill/PersonalDataManagerTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/input/SelectPopupOtherContentViewTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/signin/OAuth2TokenServiceIntegrationTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/sync/ChromiumSyncAdapterTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/sync/DelayedSyncControllerTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 4 chunks +5 lines, -5 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java View 3 chunks +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarkNodeTest.java View 1 chunk +3 lines, -3 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderTestBase.java View 2 chunks +4 lines, -4 lines 0 comments Download
chrome/android/javatests/src/org/chromium/chrome/browser/translate/TranslateInfoBarTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
chrome/android/testshell/java/AndroidManifest.xml View 2 chunks +3 lines, -3 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellActivity.java View 1 2 3 4 4 chunks +5 lines, -5 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java View 1 2 3 4 5 chunks +6 lines, -6 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromeShellApplicationObserver.java View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellActivity.java View 1 2 3 4 1 chunk +0 lines, -307 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellApplication.java View 1 2 3 4 1 chunk +0 lines, -96 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/ChromiumTestShellApplicationObserver.java View 1 2 3 4 1 chunk +0 lines, -18 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellPKCS11AuthenticationManager.java View 1 chunk +1 line, -1 line 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapter.java View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromeShellSyncAdapterService.java View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromiumTestShellSyncAdapter.java View 1 2 3 4 1 chunk +0 lines, -27 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/ChromiumTestShellSyncAdapterService.java View 1 2 3 4 1 chunk +0 lines, -19 lines 0 comments Download
chrome/android/testshell/java/src/org/chromium/chrome/shell/sync/SyncController.java View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromeShellTestBase.java View 1 2 3 4 3 chunks +12 lines, -13 lines 0 comments Download
chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromeShellUrlTest.java View 1 2 3 4 3 chunks +5 lines, -5 lines 0 comments Download
chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromiumTestShellTestBase.java View 1 2 3 4 1 chunk +0 lines, -156 lines 0 comments Download
chrome/android/testshell/javatests/src/org/chromium/chrome/shell/ChromiumTestShellUrlTest.java View 1 2 3 4 1 chunk +0 lines, -111 lines 0 comments Download
chrome/browser/android/dev_tools_server.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/devtools/devtools_adb_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/test/chromedriver/chrome/device_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/test/chromedriver/test/test_expectations View 1 chunk +1 line, -1 line 0 comments Download
tools/cr/cr/targets/chromium_testshell.py View 1 chunk +1 line, -1 line 0 comments Download
tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
aurimas (slooooooooow)
Hey Tommy, Please take a look at this CL. Thanks, Aurimas
6 years, 9 months ago (2014-03-01 00:54:59 UTC) #1
nyquist
lgtm
6 years, 9 months ago (2014-03-03 17:00:48 UTC) #2
aurimas (slooooooooow)
pfeldman@chromium.org: Please review changes in chrome/browser/devtools/ tonyg@chromium.org: Please review changes in tools/telemetry/telemetry/ craigdh@chromium.org: Please review ...
6 years, 9 months ago (2014-03-03 17:09:41 UTC) #3
nyquist
aurimas: FYI: https://codereview.chromium.org/185113002/ adds chrome/android/testshell/java/src/org/chromium/chrome/shell/TestShellSwitches.java I don't know what will land first, but I figured ...
6 years, 9 months ago (2014-03-04 16:41:21 UTC) #4
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 9 months ago (2014-03-05 17:36:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/184993005/150001
6 years, 9 months ago (2014-03-05 17:36:17 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-05 17:37:54 UTC) #7
Message was sent while issue was closed. 
Change committed as 255073

Powered by Google App Engine
This is Rietveld 408576698