chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java - Issue 184993005: Rename ChromiumTestShell classes to ChromeShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

Issue 184993005: Rename ChromiumTestShell classes to ChromeShell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase yet again Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/prerender/ExternalPrerenderRequestTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/search_engines/TemplateUrlServiceTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

index a4d04b46495b0d764025b6326a155d94e8bb220a..1355051ba31e41116e49ae40d60d4b33d168d3ec 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java

@@ -17,7 +17,7 @@ import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.TestFileUtil;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.browser.printing.TabPrinter;

-import org.chromium.chrome.shell.ChromiumTestShellTestBase;

+import org.chromium.chrome.shell.ChromeShellTestBase;

import org.chromium.chrome.shell.TestShellTab;

import java.io.File;

@@ -33,7 +33,7 @@ import java.util.concurrent.TimeUnit;

* TODO(cimamoglu): Add a test with multiple, stacked onLayout/onWrite calls.

* TODO(cimamoglu): Add a test which emulates Chromium failing to generate a PDF.

-public class PrintingControllerTest extends ChromiumTestShellTestBase {

+public class PrintingControllerTest extends ChromeShellTestBase {

private static final String TEMP_FILE_NAME = "temp_print";

private static final String TEMP_FILE_EXTENSION = ".pdf";

@@ -77,7 +77,7 @@ public class PrintingControllerTest extends ChromiumTestShellTestBase {

public void testNormalPrintingFlow() throws Throwable {

if (!ApiCompatibilityUtils.isPrintingSupported()) return;

- final TestShellTab currentTab = launchChromiumTestShellWithUrl(URL).getActiveTab();

+ final TestShellTab currentTab = launchChromeShellWithUrl(URL).getActiveTab();

assertTrue(waitForActiveShellToBeDoneLoading());

final PrintingControllerImpl printingController = createControllerOnUiThread();