chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java - Issue 184993005: Rename ChromiumTestShell classes to ChromeShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

Issue 184993005: Rename ChromiumTestShell classes to ChromeShell. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase yet again Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/test/DummyTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/test/ProviderBookmarkNodeTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

index d681a186c39fd37bb128e3459efd0700ba17c2ee..7106bace877370b1fdacc654bdc7ae4f240de9ce 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/test/ModalDialogTest.java

@@ -18,7 +18,7 @@ import org.chromium.base.test.util.DisabledTest;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.browser.JavascriptAppModalDialog;

-import org.chromium.chrome.shell.ChromiumTestShellTestBase;

+import org.chromium.chrome.shell.ChromeShellTestBase;

import org.chromium.chrome.test.util.TabUtils;

import org.chromium.chrome.test.util.TabUtils.TestCallbackHelperContainerForTab;

import org.chromium.content.browser.test.util.Criteria;

@@ -33,7 +33,7 @@ import java.util.concurrent.TimeoutException;

/**

* Test suite for displaying and functioning of modal dialogs.

-public class ModalDialogTest extends ChromiumTestShellTestBase {

+public class ModalDialogTest extends ChromeShellTestBase {

private static final String TAG = "ModalDialogTest";

private static final String EMPTY_PAGE = UrlUtils.encodeHtmlDataUri(

"<html><title>Modal Dialog Test</title><p>Testcase.</p></title></html>");

@@ -46,7 +46,7 @@ public class ModalDialogTest extends ChromiumTestShellTestBase {

@Override

public void setUp() throws Exception {

super.setUp();

- launchChromiumTestShellWithUrl(EMPTY_PAGE);

+ launchChromeShellWithUrl(EMPTY_PAGE);

assertTrue("Page failed to load", waitForActiveShellToBeDoneLoading());

}