Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: sync/protocol/sync.proto

Issue 1849563005: [Sync] Add cookie jar mismatch logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add integration test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/sync.proto
diff --git a/sync/protocol/sync.proto b/sync/protocol/sync.proto
index c8111a141111e22ac9d6a7c4827d78034c1353f7..ed06d82fadd6cd29a952aaaddbcbf74c278207bf 100644
--- a/sync/protocol/sync.proto
+++ b/sync/protocol/sync.proto
@@ -400,6 +400,11 @@ message ClientConfigParams {
// Whether the PROXY_TABS proxy datatype is enabled on this client.
optional bool tabs_datatype_enabled = 2;
+
+ // Whether the account(s) present in the content area's cookie jar matches the
maxbogue 2016/04/01 22:30:48 s/matches/match... I think? Grammar with parenthet
Nicolas Zea 2016/04/04 19:57:31 Done.
+ // chrome account. If multiple accounts a present in the cookie jar, a
maxbogue 2016/04/01 22:30:48 are present
Nicolas Zea 2016/04/04 19:57:31 Done.
+ // mismatch implies all of them must are different from the chrome account
maxbogue 2016/04/01 22:30:48 s/must//, and add a period.
Nicolas Zea 2016/04/04 19:57:31 Done.
+ optional bool cookie_jar_mismatch = 3;
};
message CommitMessage {

Powered by Google App Engine
This is Rietveld 408576698