Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: sync/sessions/sync_session_context.h

Issue 1849563005: [Sync] Add cookie jar mismatch logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add integration test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/sessions/sync_session_context.h
diff --git a/sync/sessions/sync_session_context.h b/sync/sessions/sync_session_context.h
index 194ce4632fec3d8aa761aa0ac4f5373b0689f7f9..249f82f7f68d02c588764af6450170907fcad333 100644
--- a/sync/sessions/sync_session_context.h
+++ b/sync/sessions/sync_session_context.h
@@ -126,6 +126,14 @@ class SYNC_EXPORT SyncSessionContext {
return model_type_registry_;
}
+ bool cookie_jar_mismatch() const {
+ return cookie_jar_mismatch_;
+ }
+
+ void set_cookie_jar_mismatch(bool cookie_jar_mismatch) {
+ cookie_jar_mismatch_ = cookie_jar_mismatch;
+ }
+
private:
// Rather than force clients to set and null-out various context members, we
// extend our encapsulation boundary to scoped helpers that take care of this
@@ -180,6 +188,11 @@ class SYNC_EXPORT SyncSessionContext {
// enable the pre-commit update avoidance experiment described above.
const bool client_enabled_pre_commit_update_avoidance_;
+ // Whether the account(s) present in the content area's cookie jar matches the
maxbogue 2016/04/01 22:30:48 All the same comments as for the proto.
Nicolas Zea 2016/04/04 19:57:31 Done.
+ // chrome account. If multiple accounts a present in the cookie jar, a
+ // mismatch implies all of them must are different from the chrome account
+ bool cookie_jar_mismatch_;
+
DISALLOW_COPY_AND_ASSIGN(SyncSessionContext);
};

Powered by Google App Engine
This is Rietveld 408576698