Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Side by Side Diff: sync/protocol/sync.proto

Issue 1849563005: [Sync] Add cookie jar mismatch logging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add integration test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol for communication between sync client and server. 5 // Sync protocol for communication between sync client and server.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 393
394 // Client specific configuration information. 394 // Client specific configuration information.
395 message ClientConfigParams { 395 message ClientConfigParams {
396 // The set of data types this client has enabled. Note that this does not 396 // The set of data types this client has enabled. Note that this does not
397 // include proxy types, as they do not have protocol field numbers and are 397 // include proxy types, as they do not have protocol field numbers and are
398 // placeholder types that implicitly enable protocol types. 398 // placeholder types that implicitly enable protocol types.
399 repeated int32 enabled_type_ids = 1; 399 repeated int32 enabled_type_ids = 1;
400 400
401 // Whether the PROXY_TABS proxy datatype is enabled on this client. 401 // Whether the PROXY_TABS proxy datatype is enabled on this client.
402 optional bool tabs_datatype_enabled = 2; 402 optional bool tabs_datatype_enabled = 2;
403
404 // Whether the account(s) present in the content area's cookie jar matches the
maxbogue 2016/04/01 22:30:48 s/matches/match... I think? Grammar with parenthet
Nicolas Zea 2016/04/04 19:57:31 Done.
405 // chrome account. If multiple accounts a present in the cookie jar, a
maxbogue 2016/04/01 22:30:48 are present
Nicolas Zea 2016/04/04 19:57:31 Done.
406 // mismatch implies all of them must are different from the chrome account
maxbogue 2016/04/01 22:30:48 s/must//, and add a period.
Nicolas Zea 2016/04/04 19:57:31 Done.
407 optional bool cookie_jar_mismatch = 3;
403 }; 408 };
404 409
405 message CommitMessage { 410 message CommitMessage {
406 repeated SyncEntity entries = 1; 411 repeated SyncEntity entries = 1;
407 412
408 // A GUID that identifies the committing sync client. This value will be 413 // A GUID that identifies the committing sync client. This value will be
409 // returned as originator_cache_guid for any new items. 414 // returned as originator_cache_guid for any new items.
410 optional string cache_guid = 2; 415 optional string cache_guid = 2;
411 416
412 repeated ChromiumExtensionsActivity extensions_activity = 3; 417 repeated ChromiumExtensionsActivity extensions_activity = 3;
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1023 }; 1028 };
1024 1029
1025 // A message indicating that the sync engine has been disabled on a client. 1030 // A message indicating that the sync engine has been disabled on a client.
1026 message SyncDisabledEvent { 1031 message SyncDisabledEvent {
1027 // The GUID that identifies the sync client. 1032 // The GUID that identifies the sync client.
1028 optional string cache_guid = 1; 1033 optional string cache_guid = 1;
1029 1034
1030 // The store birthday that the client was using before disabling sync. 1035 // The store birthday that the client was using before disabling sync.
1031 optional string store_birthday = 2; 1036 optional string store_birthday = 2;
1032 }; 1037 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698