core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp - Issue 1849443003: Re-enable all the windows warnings except 4267

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

Issue 1849443003: Re-enable all the windows warnings except 4267 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp b/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

index a4b85a34faa2fc3905c60707e56b89ea4052dafa..72addc1889ec87c718401af835770a7d3ac664fe 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp

@@ -722,7 +722,8 @@ FX_BOOL CPDF_DataAvail::IsDataAvail(FX_FILESIZE offset,

FX_SAFE_DWORD safeSize = pdfium::base::checked_cast<uint32_t>(offset);

Tom Sepez 2016/03/30 23:28:28 If this were a FX_SAFE_FILESIZE, we could avoid al

Wei Li 2016/03/31 01:39:08 Good idea, done.

safeSize += size;

safeSize += 512;

- if (!safeSize.IsValid() || safeSize.ValueOrDie() > m_dwFileLen)

+ if (!safeSize.IsValid() ||

+ safeSize.ValueOrDie() > static_cast<uint32_t>(m_dwFileLen))

size = m_dwFileLen - offset;

else

size += 512;