core/fpdfapi/fpdf_parser/cpdf_parser.cpp - Issue 1849443003: Re-enable all the windows warnings except 4267

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

Issue 1849443003: Re-enable all the windows warnings except 4267 (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_parser.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

index 305401525ce62ed28b27d020d5bb4a2e240a1a14..2002e3c9e7180ce1f02d35094b0683ec562413b7 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_parser.cpp

@@ -186,7 +186,8 @@ CPDF_Parser::Error CPDF_Parser::StartParse(IFX_FileRead* pFileAccess) {

if (std::isdigit(ch))

m_FileVersion += FXSYS_toDecimalDigit(static_cast<FX_WCHAR>(ch));

- if (m_pSyntax->m_FileLen < m_pSyntax->m_HeaderOffset + 9)

+ if (static_cast<uint32_t>(m_pSyntax->m_FileLen) <

+ m_pSyntax->m_HeaderOffset + 9)

Tom Sepez 2016/03/30 23:28:28 Maybe m_HeaderOffset should be a FX_FILESIZE, too.

Wei Li 2016/03/31 01:39:09 Done.

return FORMAT_ERROR;

m_pSyntax->RestorePos(m_pSyntax->m_FileLen - m_pSyntax->m_HeaderOffset - 9);