Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849303002: Disable some extensions_unittests on LSAN builds. (Closed)

Created:
4 years, 8 months ago by Łukasz Anforowicz
Modified:
4 years, 8 months ago
Reviewers:
Devlin, sammc
CC:
chromium-reviews, extensions-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, chromium-apps-reviews_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable some extensions_unittests on LSAN builds. BUG=599898 TBR=sammc@chromium.org, rdevlin.cronin@chromium.org Committed: https://crrev.com/25fc1ad753fab8c79694b54946ad84dd29812bb1 Cr-Commit-Position: refs/heads/master@{#384640}

Patch Set 1 #

Patch Set 2 : Self-review... #

Patch Set 3 : Added a missing MAYBE_ prefix to DataSenderTest.Close #

Patch Set 4 : Ok - let's push it out to CQ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -12 lines) Patch
M extensions/renderer/api/serial/data_receiver_unittest.cc View 1 2 chunks +21 lines, -3 lines 0 comments Download
M extensions/renderer/api/serial/data_sender_unittest.cc View 1 2 4 chunks +28 lines, -4 lines 0 comments Download
M extensions/renderer/api/serial/serial_api_unittest.cc View 3 chunks +28 lines, -4 lines 0 comments Download
M extensions/renderer/mojo/stash_client_unittest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849303002/1
4 years, 8 months ago (2016-04-01 17:21:45 UTC) #3
Łukasz Anforowicz
rdevlin.cronin@ + sammc@, could you please take a look? (rdevlin.cronin@ as owner of //extensions, sammc@ ...
4 years, 8 months ago (2016-04-01 17:23:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849303002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849303002/60001
4 years, 8 months ago (2016-04-01 17:43:08 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-01 18:37:14 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 18:38:22 UTC) #12
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/25fc1ad753fab8c79694b54946ad84dd29812bb1
Cr-Commit-Position: refs/heads/master@{#384640}

Powered by Google App Engine
This is Rietveld 408576698