Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: extensions/renderer/api/serial/data_receiver_unittest.cc

Issue 1849303002: Disable some extensions_unittests on LSAN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ok - let's push it out to CQ... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/renderer/api/serial/data_sender_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api/serial/data_receiver_unittest.cc
diff --git a/extensions/renderer/api/serial/data_receiver_unittest.cc b/extensions/renderer/api/serial/data_receiver_unittest.cc
index 0827a8a247f324a293b8359a6e0fc96bfbc9d298..0c7dc000d8a22475cbc735b71580a2551b873a3c 100644
--- a/extensions/renderer/api/serial/data_receiver_unittest.cc
+++ b/extensions/renderer/api/serial/data_receiver_unittest.cc
@@ -126,12 +126,24 @@ class DataReceiverTest : public ApiTestBase {
DISALLOW_COPY_AND_ASSIGN(DataReceiverTest);
};
-TEST_F(DataReceiverTest, Receive) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_Receive DISABLED_Receive
+#else
+#define MAYBE_Receive Receive
+#endif
+TEST_F(DataReceiverTest, MAYBE_Receive) {
data_to_send_.push("a");
RunTest("data_receiver_unittest.js", "testReceive");
}
-TEST_F(DataReceiverTest, ReceiveError) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_ReceiveError DISABLED_ReceiveError
+#else
+#define MAYBE_ReceiveError ReceiveError
+#endif
+TEST_F(DataReceiverTest, MAYBE_ReceiveError) {
error_to_send_.push(1);
RunTest("data_receiver_unittest.js", "testReceiveError");
}
@@ -176,7 +188,13 @@ TEST_F(DataReceiverTest, SerializeDuringReceive) {
RunTest("data_receiver_unittest.js", "testSerializeDuringReceive");
}
-TEST_F(DataReceiverTest, SerializeAfterClose) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_SerializeAfterClose DISABLED_SerializeAfterClose
+#else
+#define MAYBE_SerializeAfterClose SerializeAfterClose
+#endif
+TEST_F(DataReceiverTest, MAYBE_SerializeAfterClose) {
data_to_send_.push("a");
RunTest("data_receiver_unittest.js", "testSerializeAfterClose");
}
« no previous file with comments | « no previous file | extensions/renderer/api/serial/data_sender_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698