Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: extensions/renderer/api/serial/data_sender_unittest.cc

Issue 1849303002: Disable some extensions_unittests on LSAN builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Ok - let's push it out to CQ... Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/api/serial/data_sender_unittest.cc
diff --git a/extensions/renderer/api/serial/data_sender_unittest.cc b/extensions/renderer/api/serial/data_sender_unittest.cc
index c9a75cc4656fa41552aa37bf5e7644b066df3ec7..a38dd10f201a6c6e4443c4924792b77604533d43 100644
--- a/extensions/renderer/api/serial/data_sender_unittest.cc
+++ b/extensions/renderer/api/serial/data_sender_unittest.cc
@@ -95,7 +95,13 @@ TEST_F(DataSenderTest, Send) {
RunTest("data_sender_unittest.js", "testSend");
}
-TEST_F(DataSenderTest, LargeSend) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_LargeSend DISABLED_LargeSend
+#else
+#define MAYBE_LargeSend LargeSend
+#endif
+TEST_F(DataSenderTest, MAYBE_LargeSend) {
std::string pattern = "123";
std::string expected_data;
for (int i = 0; i < 11; i++)
@@ -146,7 +152,13 @@ TEST_F(DataSenderTest, SendErrorBeforeLargeSend) {
RunTest("data_sender_unittest.js", "testSendErrorBeforeLargeSend");
}
-TEST_F(DataSenderTest, CancelWithoutSend) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_CancelWithoutSend DISABLED_CancelWithoutSend
+#else
+#define MAYBE_CancelWithoutSend CancelWithoutSend
+#endif
+TEST_F(DataSenderTest, MAYBE_CancelWithoutSend) {
RunTest("data_sender_unittest.js", "testCancelWithoutSend");
}
@@ -154,7 +166,13 @@ TEST_F(DataSenderTest, Cancel) {
RunTest("data_sender_unittest.js", "testCancel");
}
-TEST_F(DataSenderTest, Close) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_Close DISABLED_Close
+#else
+#define MAYBE_Close Close
+#endif
+TEST_F(DataSenderTest, MAYBE_Close) {
RunTest("data_sender_unittest.js", "testClose");
}
@@ -182,7 +200,13 @@ TEST_F(DataSenderTest, SerializeWaitsForCancel) {
RunTest("data_sender_unittest.js", "testSerializeWaitsForCancel");
}
-TEST_F(DataSenderTest, SerializeAfterClose) {
+// https://crbug.com/599898
+#if defined(LEAK_SANITIZER)
+#define MAYBE_SerializeAfterClose DISABLED_SerializeAfterClose
+#else
+#define MAYBE_SerializeAfterClose SerializeAfterClose
+#endif
+TEST_F(DataSenderTest, MAYBE_SerializeAfterClose) {
RunTest("data_sender_unittest.js", "testSerializeAfterClose");
}
« no previous file with comments | « extensions/renderer/api/serial/data_receiver_unittest.cc ('k') | extensions/renderer/api/serial/serial_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698