Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Unified Diff: content/renderer/media/media_stream_video_renderer_sink.cc

Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nick's PS3 comments (moving non-observer impl out of MSVideoSink interface). Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_renderer_sink.cc
diff --git a/content/renderer/media/media_stream_video_renderer_sink.cc b/content/renderer/media/media_stream_video_renderer_sink.cc
index beaff401e26c62fae18b547437d22975957a7ad5..8e9eccd33f81245c689301d2434f9aad89f9fe27 100644
--- a/content/renderer/media/media_stream_video_renderer_sink.cc
+++ b/content/renderer/media/media_stream_video_renderer_sink.cc
@@ -50,13 +50,11 @@ void MediaStreamVideoRendererSink::Start() {
DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK_EQ(state_, STOPPED);
- AddToVideoTrack(
- this,
+ MediaStreamVideoSink::ConnectToTrack(video_track_,
media::BindToCurrentLoop(
base::Bind(
&MediaStreamVideoRendererSink::OnVideoFrame,
- weak_factory_.GetWeakPtr())),
- video_track_);
+ weak_factory_.GetWeakPtr())));
state_ = STARTED;
if (video_track_.source().getReadyState() ==
@@ -69,7 +67,7 @@ void MediaStreamVideoRendererSink::Start() {
void MediaStreamVideoRendererSink::Stop() {
DCHECK(task_runner_->BelongsToCurrentThread());
DCHECK(state_ == STARTED || state_ == PAUSED);
- RemoveFromVideoTrack(this, video_track_);
+ MediaStreamVideoSink::DisconnectFromTrack();
weak_factory_.InvalidateWeakPtrs();
state_ = STOPPED;
frame_size_.set_width(kMinFrameSize);
« no previous file with comments | « content/renderer/media/media_stream_video_renderer_sink.h ('k') | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698