content/renderer/media/media_stream_video_source.cc - Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_source.cc

Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nick's PS3 comments (moving non-observer impl out of MSVideoSink interface). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_video_renderer_sink.cc ('k') | content/renderer/media/media_stream_video_source_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_source.cc

diff --git a/content/renderer/media/media_stream_video_source.cc b/content/renderer/media/media_stream_video_source.cc

index 9e4eeb97216ece6f93e8239d877318e57cfb19fb..c40638c82930df5d4fd853c792fef5bd6a297974 100644

--- a/content/renderer/media/media_stream_video_source.cc

+++ b/content/renderer/media/media_stream_video_source.cc

@@ -298,6 +298,10 @@ media::VideoCaptureFormat GetBestCaptureFormat(

// static

MediaStreamVideoSource* MediaStreamVideoSource::GetVideoSource(

const blink::WebMediaStreamSource& source) {

+ if (source.isNull() ||

+ source.getType() != blink::WebMediaStreamSource::TypeVideo) {

+ return nullptr;

+ }

return static_cast<MediaStreamVideoSource*>(source.getExtraData());

}