content/renderer/media/media_stream_video_renderer_sink.h - Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_video_renderer_sink.h

Issue 1849003002: Add video frame refresh to MediaStream and VideoCapture stacks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nick's PS3 comments (moving non-observer impl out of MSVideoSink interface). Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/media/media_stream_video_capturer_source_unittest.cc ('k') | content/renderer/media/media_stream_video_renderer_sink.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_video_renderer_sink.h

diff --git a/content/renderer/media/media_stream_video_renderer_sink.h b/content/renderer/media/media_stream_video_renderer_sink.h

index ad3c9eb669805fdf7ff6106789e485dcb8dfef08..ac3329696414d2ab89315c598ec9e51b357d6823 100644

--- a/content/renderer/media/media_stream_video_renderer_sink.h

+++ b/content/renderer/media/media_stream_video_renderer_sink.h

@@ -30,9 +30,9 @@ namespace content {

// MediaStreamVideoRendererSink is a VideoFrameProvider designed for rendering

// Video MediaStreamTracks [1], MediaStreamVideoRendererSink implements

// MediaStreamVideoSink in order to render video frames provided from a

-// MediaStreamVideoTrack, to which it AddToVideoTrack()s itself when the

-// VideoFrameProvider is Start()ed and RemoveFromVideoTrack()s itself when the

-// latter is Stop()ed.

+// MediaStreamVideoTrack, to which it connects itself when the

+// VideoFrameProvider is Start()ed, and disconnects itself when the latter is

+// Stop()ed.

// [1] http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastreamtrack