Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1848923003: Revert of Make Android StreamTexture implement GLStreamTextureImage (Closed)

Created:
4 years, 8 months ago by Daniel Kurtz
Modified:
4 years, 8 months ago
CC:
avayvod+watch_chromium.org, ccameron, chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-media_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make Android StreamTexture implement GLStreamTextureImage (patchset #9 id:180001 of https://codereview.chromium.org/1746983002/ ) Reason for revert: A git bisect suggests that this patch makes Youtube and Hangouts appear upside-down on Chrome OS. BUG=599848 Original issue's description: > Make Android StreamTexture implement GLStreamTextureImage > > Then make CopySubTextureCHROMIUM use the transform matrix provided > by GLStreamTextureImage, and stop informing the compositor of the > transform matrix. Video quad drawing applies the matrix automatically > via the CHROMIUM_stream_texture_matrix extension. > > This has has the advantage that we no longer need custom texture copying > code in StreamTextureAndroid and we also don't need the IPC that updates > the compositor view of the transform matrix (because it is applied > transparently when the texture is sampled from). This in turn means that > the transform matrix can't get out of sync with the texture data. > > BUG=226218, 371500, 588837 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Committed: https://crrev.com/8f2032aeb81c2a6a48ed2ed622859b59d84fbbaa > Cr-Commit-Position: refs/heads/master@{#384122} TBR=dalecurtis@chromium.org,danakj@chromium.org,dcheng@chromium.org,liberato@chromium.org,sievers@chromium.org,enne@chromium.org,tobiasjs@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=226218, 371500, 588837 Committed: https://crrev.com/e6dac6465349eccf7d9cf5850be54cea24631095 Cr-Commit-Position: refs/heads/master@{#384824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -132 lines) Patch
M cc/layers/video_frame_provider.h View 1 chunk +3 lines, -0 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.cc View 3 chunks +25 lines, -0 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl_unittest.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M content/common/gpu/stream_texture_android.h View 4 chunks +4 lines, -5 lines 0 comments Download
M content/common/gpu/stream_texture_android.cc View 7 chunks +116 lines, -13 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_synchronous_impl.cc View 2 chunks +23 lines, -1 line 0 comments Download
M content/renderer/media/webmediaplayer_ms_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/gl_stream_texture_image.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.h View 1 chunk +0 lines, -22 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_copy_texture_chromium.cc View 1 chunk +1 line, -30 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +47 lines, -48 lines 0 comments Download
M gpu/ipc/common/gpu_messages.h View 2 chunks +25 lines, -0 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Daniel Kurtz
Created Revert of Make Android StreamTexture implement GLStreamTextureImage
4 years, 8 months ago (2016-04-01 17:24:46 UTC) #1
Daniel Kurtz
4 years, 8 months ago (2016-04-01 17:24:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848923003/1
4 years, 8 months ago (2016-04-01 17:25:33 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-01 17:25:35 UTC) #5
DaleCurtis
lgtm
4 years, 8 months ago (2016-04-01 17:32:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848923003/1
4 years, 8 months ago (2016-04-02 12:56:20 UTC) #10
Daniel Kurtz
4 years, 8 months ago (2016-04-02 12:56:24 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/198468)
4 years, 8 months ago (2016-04-02 17:34:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848923003/1
4 years, 8 months ago (2016-04-03 01:55:32 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-03 03:26:14 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-04-03 03:27:50 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6dac6465349eccf7d9cf5850be54cea24631095
Cr-Commit-Position: refs/heads/master@{#384824}

Powered by Google App Engine
This is Rietveld 408576698