Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1848653006: Random wm frame painting fixes (Closed)

Created:
4 years, 8 months ago by sky
Modified:
4 years, 8 months ago
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Random wm frame painting fixes . Buttons are painted correctly based on active state. . Makes task viewer resizable. BUG=none TEST=none R=ben@chromium.org Committed: https://crrev.com/423bc2bc55384368cb9d1ed509d7ac44f8723f54 Cr-Commit-Position: refs/heads/master@{#384377}

Patch Set 1 #

Patch Set 2 : override #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -36 lines) Patch
M components/mus/public/cpp/lib/window.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/mus/public/cpp/window.h View 1 chunk +1 line, -1 line 0 comments Download
M mash/task_viewer/task_viewer.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.h View 1 4 chunks +14 lines, -1 line 0 comments Download
M mash/wm/frame/non_client_frame_view_mash.cc View 7 chunks +45 lines, -10 lines 0 comments Download
M mash/wm/non_client_frame_controller.h View 2 chunks +6 lines, -3 lines 0 comments Download
M mash/wm/non_client_frame_controller.cc View 3 chunks +22 lines, -10 lines 0 comments Download
M mash/wm/property_util.h View 2 chunks +5 lines, -2 lines 0 comments Download
M mash/wm/property_util.cc View 3 chunks +25 lines, -3 lines 0 comments Download
M mash/wm/window_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
sky
4 years, 8 months ago (2016-03-31 17:24:01 UTC) #1
Ben Goodger (Google)
lgtm
4 years, 8 months ago (2016-03-31 17:25:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848653006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848653006/1
4 years, 8 months ago (2016-03-31 17:31:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/151622)
4 years, 8 months ago (2016-03-31 17:53:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848653006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848653006/20001
4 years, 8 months ago (2016-03-31 19:30:59 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-03-31 20:48:22 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 20:50:50 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/423bc2bc55384368cb9d1ed509d7ac44f8723f54
Cr-Commit-Position: refs/heads/master@{#384377}

Powered by Google App Engine
This is Rietveld 408576698