Random wm frame painting fixes

mash/wm/non_client_frame_controller.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/wm/non_client_frame_controller.h"
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "components/mus/public/cpp/property_type_converters.h"
@@ skipping 155 matching lines @@
   }
 
  private:
   NonClientFrameController* frame_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(ClientViewMus);
 };
 
 }  // namespace
 
+// static
+void NonClientFrameController::Create(
+    mojo::Connector* connector,
+    mus::Window* window,
+    mus::WindowManagerClient* window_manager_client) {
+  new NonClientFrameController(connector, window, window_manager_client);
+}
+
+// static
+gfx::Insets NonClientFrameController::GetPreferredClientAreaInsets() {
+  return NonClientFrameViewMash::GetPreferredClientAreaInsets();
+}
+
+// static
+int NonClientFrameController::GetMaxTitleBarButtonWidth() {
+  return NonClientFrameViewMash::GetMaxTitleBarButtonWidth();
+}
+
 NonClientFrameController::NonClientFrameController(
     mojo::Connector* connector,
     mus::Window* window,
     mus::WindowManagerClient* window_manager_client)
     : widget_(new views::Widget), window_(window) {
   window_->AddObserver(this);
 
+  // To simplify things this code creates a Widget. While a Widget is created
+  // we need to ensure we don't inadvertently change random properties of the
+  // underlying mus::Window. For example, showing the Widget shouldn't change
+  // the bounds of the mus::Window in anyway.
   views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
   // We initiate focus at the mus level, not at the views level.
   params.activatable = views::Widget::InitParams::ACTIVATABLE_NO;
   params.delegate = this;
   params.native_widget = new WmNativeWidgetMus(widget_, connector, window);
   widget_->Init(params);
   widget_->ShowInactive();
 
   const int shadow_inset =
       Shadow::GetInteriorInsetForStyle(Shadow::STYLE_ACTIVE);
   window_manager_client->SetUnderlaySurfaceOffsetAndExtendedHitArea(
       window, gfx::Vector2d(shadow_inset, shadow_inset),
       FrameBorderHitTestController::GetResizeOutsideBoundsSize());
 }
 
-// static
-gfx::Insets NonClientFrameController::GetPreferredClientAreaInsets() {
-  return NonClientFrameViewMash::GetPreferredClientAreaInsets();
-}
-
-// static
-int NonClientFrameController::GetMaxTitleBarButtonWidth() {
-  return NonClientFrameViewMash::GetMaxTitleBarButtonWidth();
-}
-
 NonClientFrameController::~NonClientFrameController() {
   if (window_)
     window_->RemoveObserver(this);
 }
 
 base::string16 NonClientFrameController::GetWindowTitle() const {
   if (!window_->HasSharedProperty(
           mus::mojom::WindowManager::kWindowTitle_Property)) {
     return base::string16();
   }
@@ skipping 40 matching lines @@
     widget_->UpdateWindowTitle();
 }
 
 void NonClientFrameController::OnWindowDestroyed(mus::Window* window) {
   window_->RemoveObserver(this);
   window_ = nullptr;
 }
 
 }  // namespace wm
 }  // namespace mash