Random wm frame painting fixes

mash/wm/frame/non_client_frame_view_mash.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mash/wm/frame/non_client_frame_view_mash.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/macros.h"
 #include "components/mus/public/cpp/window.h"
+#include "components/mus/public/cpp/window_tree_connection.h"
 #include "grit/mash_wm_resources.h"
 #include "mash/wm/frame/caption_buttons/frame_caption_button_container_view.h"
 #include "mash/wm/frame/default_header_painter.h"
 #include "mash/wm/frame/frame_border_hit_test_controller.h"
 #include "mash/wm/frame/header_painter.h"
 #include "mojo/converters/input_events/input_events_type_converters.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/compositor/paint_recorder.h"
 #include "ui/gfx/canvas.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/rect_conversions.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/image/image.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 
 namespace mash {
 namespace wm {
 
 ///////////////////////////////////////////////////////////////////////////////
 // NonClientFrameViewMash::HeaderView
 
 // View which paints the header.
 class NonClientFrameViewMash::HeaderView : public views::View {
  public:
   // |frame| is the widget that the caption buttons act on.
-  explicit HeaderView(views::Widget* frame);
+  HeaderView(views::Widget* frame, mus::Window* window);
   ~HeaderView() override;
 
   // Schedules a repaint for the entire title.
   void SchedulePaintForTitle();
 
   // Tells the window controls to reset themselves to the normal state.
   void ResetWindowControls();
 
   // Returns the view's preferred height.
   int GetPreferredHeight() const;
@@ skipping 17 matching lines @@
  private:
   // The widget that the caption buttons act on.
   views::Widget* frame_;
 
   // Helper for painting the header.
   scoped_ptr<DefaultHeaderPainter> header_painter_;
 
   // View which contains the window caption buttons.
   FrameCaptionButtonContainerView* caption_button_container_;
 
+  mus::Window* window_;
+
   DISALLOW_COPY_AND_ASSIGN(HeaderView);
 };
 
-NonClientFrameViewMash::HeaderView::HeaderView(views::Widget* frame)
+NonClientFrameViewMash::HeaderView::HeaderView(views::Widget* frame,
+                                               mus::Window* window)
     : frame_(frame),
       header_painter_(new DefaultHeaderPainter),
-      caption_button_container_(nullptr) {
+      caption_button_container_(nullptr),
+      window_(window) {
   caption_button_container_ = new FrameCaptionButtonContainerView(frame_);
   caption_button_container_->UpdateSizeButtonVisibility();
   AddChildView(caption_button_container_);
 
   header_painter_->Init(frame_, this, caption_button_container_);
 }
 
 NonClientFrameViewMash::HeaderView::~HeaderView() {}
 
 void NonClientFrameViewMash::HeaderView::SchedulePaintForTitle() {
@@ skipping 25 matching lines @@
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // NonClientFrameViewMash::HeaderView, views::View overrides:
 
 void NonClientFrameViewMash::HeaderView::Layout() {
   header_painter_->LayoutHeader();
 }
 
 void NonClientFrameViewMash::HeaderView::OnPaint(gfx::Canvas* canvas) {
-  bool paint_as_active =
-      frame_->non_client_view()->frame_view()->ShouldPaintAsActive();
+  const mus::Window* focused_window = window_->connection()->GetFocusedWindow();
+  const bool paint_as_active =
+      focused_window && window_->Contains(focused_window);
   caption_button_container_->SetPaintAsActive(paint_as_active);
 
   HeaderPainter::Mode header_mode = paint_as_active
                                         ? HeaderPainter::MODE_ACTIVE
                                         : HeaderPainter::MODE_INACTIVE;
   header_painter_->PaintHeader(canvas, header_mode);
 }
 
 void NonClientFrameViewMash::HeaderView::ChildPreferredSizeChanged(
     views::View* child) {
   // FrameCaptionButtonContainerView animates the visibility changes in
   // UpdateSizeButtonVisibility(false). Due to this a new size is not available
   // until the completion of the animation. Layout in response to the preferred
   // size changes.
   if (child != caption_button_container_)
     return;
   parent()->Layout();
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NonClientFrameViewMash, public:
 
 // static
 const char NonClientFrameViewMash::kViewClassName[] = "NonClientFrameViewMash";
 
 NonClientFrameViewMash::NonClientFrameViewMash(views::Widget* frame,
                                                mus::Window* window)
-    : frame_(frame), window_(window), header_view_(new HeaderView(frame)) {
+    : frame_(frame),
+      window_(window),
+      header_view_(new HeaderView(frame, window)) {
   // |header_view_| is set as the non client view's overlay view so that it can
   // overlay the web contents in immersive fullscreen.
   AddChildView(header_view_);
   window_->AddObserver(this);
+  window_->connection()->AddObserver(this);
 }
 
 NonClientFrameViewMash::~NonClientFrameViewMash() {
-  if (window_)
-    window_->RemoveObserver(this);
+  RemoveObservers();
 }
 
 // static
 gfx::Insets NonClientFrameViewMash::GetPreferredClientAreaInsets() {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   const int header_height =
       rb.GetImageSkiaNamed(IDR_MASH_WM_WINDOW_CONTROL_BACKGROUND_P)
           ->size()
           .height();
   return gfx::Insets(header_height, 0, 0, 0);
@@ skipping 123 matching lines @@
 
   Layout();
   // NonClientView (our parent) positions the client view based on bounds from
   // us. We need to layout from parent to trigger a layout of the client view.
   if (parent())
     parent()->Layout();
   SchedulePaint();
 }
 
 void NonClientFrameViewMash::OnWindowDestroyed(mus::Window* window) {
-  window_->RemoveObserver(this);
-  window_ = nullptr;
+  RemoveObservers();
+}
+
+void NonClientFrameViewMash::OnWindowSharedPropertyChanged(
+    mus::Window* window,
+    const std::string& name,
+    const std::vector<uint8_t>* old_data,
+    const std::vector<uint8_t>* new_data) {
+  if (name == mus::mojom::WindowManager::kResizeBehavior_Property)
+    header_view_->SizeConstraintsChanged();
+  else if (name == mus::mojom::WindowManager::kWindowTitle_Property)
+    header_view_->SchedulePaintForTitle();
 }
 
 views::View* NonClientFrameViewMash::GetHeaderView() {
   return header_view_;
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NonClientFrameViewMash, private:
 
 int NonClientFrameViewMash::NonClientTopBorderHeight() const {
   return header_view_->GetPreferredHeight();
 }
 
+void NonClientFrameViewMash::RemoveObservers() {
+  if (!window_)
+    return;
+
+  window_->RemoveObserver(this);
+  window_->connection()->RemoveObserver(this);
+  window_ = nullptr;
+}
+
+void NonClientFrameViewMash::OnWindowTreeFocusChanged(mus::Window* gained_focus,
+                                                      mus::Window* lost_focus) {
+  const bool had_focus = lost_focus && window_->Contains(lost_focus);
+  const bool has_focus = gained_focus && window_->Contains(gained_focus);
+  if (had_focus != has_focus)
+    SchedulePaint();
+}
+
 }  // namespace wm
 }  // namespace mash