Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 184853009: Revert of Move all RefPtr's to CSSValue to oilpan transition types (Closed)

Created:
6 years, 9 months ago by wibling-chromium
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, rune+blink, dglazkov+blink, dstockwell, Timothy Loh, apavlov+blink_chromium.org, darktears, Steve Block, dino_apple.com, Eric Willigers
Visibility:
Public.

Description

Revert of Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. (https://codereview.chromium.org/184313004/) Reason for revert: It seems to break some of our layout tests. Original issue's description: > Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue. > > This change gets rid of all but one RefPtr to CSSValue. I have introduced a few persistents core/animation/..., core/css/StylePropertySet, and ElementStyleResources. I plan to attack the one in CSSCursorImageValue subsequently, and then change CSSValue from RefCountedGarbageCollected to GarbageCollectedFinalized. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org > BUG=341815 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168466 TBR=ager@chromium.org,erik.corry@gmail.com,haraken@chromium.org,oilpan-reviews@chromium.org,tkent@chromium.org,vegorov@chromium.org,zerny@chromium.org NOTREECHECKS=true NOTRY=true BUG=341815 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -47 lines) Patch
M Source/core/animation/AnimatableNeutralTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableUnknown.h View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/animation/AnimatableUnknownTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSProperty.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.h View 2 chunks +22 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueList.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/CSSValueList.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/core/css/StylePropertySerializer.cpp View 7 chunks +9 lines, -9 lines 0 comments Download
M Source/core/css/StylePropertySet.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/StylePropertySet.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/css/parser/CSSPropertyParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/AnimatedStyleBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/css/resolver/ElementStyleResources.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
wibling-chromium
Created Revert of Move all RefPtr's to CSSValue to oilpan transition types, except for the ...
6 years, 9 months ago (2014-03-05 15:52:57 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-05 15:54:04 UTC) #2
commit-bot: I haz the power
Change committed as 168492
6 years, 9 months ago (2014-03-05 15:54:50 UTC) #3
zerny-chromium
6 years, 9 months ago (2014-03-05 16:57:09 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698